Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl interval type #1952

Merged
merged 14 commits into from
Jul 31, 2023
Merged

feat: impl interval type #1952

merged 14 commits into from
Jul 31, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Jul 13, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

closes #1886

@v0y4g3r v0y4g3r added the docs-required This change requires docs update. label Jul 13, 2023
@sunng87 sunng87 mentioned this pull request Jul 13, 2023
Closed
@waynexia waynexia changed the title feat:impl interval type feat: impl interval type Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #1952 (17c42b1) into develop (6953986) will decrease coverage by 0.37%.
The diff coverage is 83.00%.

❗ Current head 17c42b1 differs from pull request most recent head 9184b84. Consider uploading reports for the commit 9184b84 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1952      +/-   ##
===========================================
- Coverage    85.25%   84.88%   -0.37%     
===========================================
  Files          664      667       +3     
  Lines       104783   105516     +733     
===========================================
+ Hits         89333    89570     +237     
- Misses       15450    15946     +496

@QuenKar QuenKar marked this pull request as draft July 14, 2023 06:26
@QuenKar QuenKar marked this pull request as ready for review July 16, 2023 09:46
@killme2008 killme2008 mentioned this pull request Jul 17, 2023
Merged
2 tasks
@QuenKar QuenKar force-pushed the feat-interval-type branch from 354ef9e to 84de48d Compare July 18, 2023 08:21
@QuenKar QuenKar marked this pull request as draft July 20, 2023 03:16
@QuenKar QuenKar marked this pull request as ready for review July 20, 2023 08:11
@QuenKar

This comment was marked as resolved.

Sign in to view
evenyag
evenyag reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, I think you could open a PR to add files like src/common/time/src/interval.rs first. This file has over 700 lines and doesn't depend on other changes in this PR.

src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/primitive.rs Outdated Show resolved Hide resolved
src/servers/src/postgres/types.rs Show resolved Hide resolved
tests/cases/standalone/common/select/dummy.sql Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Show resolved Hide resolved
@QuenKar
Copy link
Contributor Author

QuenKar commented Jul 20, 2023

Next time, I think you could open a PR to add files like src/common/time/src/interval.rs first. This file has over 700 lines and doesn't depend on other changes in this PR.

Ok，Thank you for your suggestion.

v0y4g3r
v0y4g3r reviewed Jul 21, 2023
View reviewed changes
src/common/grpc/src/select.rs Show resolved Hide resolved
src/common/time/src/error.rs Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/common/time/src/interval.rs Show resolved Hide resolved
src/common/time/src/interval.rs Outdated Show resolved Hide resolved
src/datatypes/src/type_id.rs Outdated Show resolved Hide resolved
evenyag
evenyag approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. It'd be great if we support interval type in our pg protocol implementation. But I think we could track it in another issue and open a new PR for it #1952 (comment)

@QuenKar QuenKar force-pushed the feat-interval-type branch from 17c42b1 to 2af7a27 Compare July 25, 2023 14:11
@QuenKar QuenKar mentioned this pull request Jul 26, 2023
Closed
2 tasks
@QuenKar QuenKar requested a review from v0y4g3r July 26, 2023 03:18
v0y4g3r
v0y4g3r approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please go ahead 💪

@v0y4g3r v0y4g3r added this pull request to the merge queue Jul 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 31, 2023
@killme2008
Copy link
Contributor

killme2008 commented Jul 31, 2023 •
edited
Loading

@QuenKar There are some conflicts that have to be resolved.

@QuenKar QuenKar force-pushed the feat-interval-type branch from 2af7a27 to 9184b84 Compare July 31, 2023 03:31
@QuenKar
Copy link
Contributor Author

QuenKar commented Jul 31, 2023

@QuenKar There are some conflicts that have to be resolved.

I solved it (•̀ᴗ• )

@killme2008 killme2008 added this pull request to the merge queue Jul 31, 2023
Merged via the queue into GreptimeTeam:develop with commit 7727508 Jul 31, 2023
@QuenKar QuenKar deleted the feat-interval-type branch July 31, 2023 04:13
This was referenced Aug 2, 2023
Merged
Merged
Closed
@QuenKar QuenKar mentioned this pull request Aug 10, 2023
Merged
2 tasks
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@QuenKar @evenyag @paomian
feat: impl interval type (GreptimeTeam#1952)
7b2d54f 
* feat: impl interval type in common time

* feat: impl datatype, vectors, value for interval

    pick 0c1d9f2 feat: impl interval type in common time
    pick d528c64 feat: impl datatype, vectors, value for interval
    pick 1e12dd5 comments update
    pick 74103e3 add license header

* comments update

* add license header

* cargo clippy

* refactor interval type

* add unit test and case to dummy.sql

* cargo clippy

* chore: add doc comments

* chore: cargo fmt

* feat: add formats, refactor comparison

* add docs comments

* Apply suggestions from code review

Co-authored-by: Yingwen <[email protected]>

* chore: cr comment

---------

Co-authored-by: Yingwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to convert arrow schema, source: Unsupported arrow data type, type: Interval(MonthDayNano)
4 participants
@QuenKar @killme2008 @v0y4g3r @evenyag