Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support frontend-meta heartbeat #1555

Merged

Conversation

fengys1996
Copy link
Contributor

@fengys1996 fengys1996 commented May 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly support the heartbeat mechanism between frontend and meta.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengys1996 fengys1996 marked this pull request as ready for review May 10, 2023 07:00
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1555 (f5b2cf6) into develop (497b1f9) will decrease coverage by 0.60%.
The diff coverage is 58.91%.

❗ Current head f5b2cf6 differs from pull request most recent head edcb2ad. Consider uploading reports for the commit edcb2ad to get more accurate results

@@             Coverage Diff             @@
##           develop    #1555      +/-   ##
===========================================
- Coverage    85.49%   84.89%   -0.60%     
===========================================
  Files          537      538       +1     
  Lines        85153    85273     +120     
===========================================
- Hits         72800    72396     -404     
- Misses       12353    12877     +524     

src/frontend/src/heartbeat.rs Outdated Show resolved Hide resolved
src/frontend/src/heartbeat.rs Outdated Show resolved Hide resolved
src/frontend/src/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
src/frontend/src/heartbeat.rs Show resolved Hide resolved
@sunng87 sunng87 added the docs-required This change requires docs update. label May 11, 2023
@fengys1996 fengys1996 force-pushed the feat/frontend/heartbeat branch from c249e59 to 7d006e8 Compare May 11, 2023 03:43
src/frontend/src/error.rs Outdated Show resolved Hide resolved
src/frontend/src/error.rs Outdated Show resolved Hide resolved
src/datanode/src/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor Author

Solved, PTAL @MichaelScofield @fengjiachun

@fengys1996 fengys1996 force-pushed the feat/frontend/heartbeat branch from cb5a5df to 4463a5a Compare May 11, 2023 08:04
src/frontend/src/error.rs Show resolved Hide resolved
src/frontend/src/heartbeat.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/heartbeat.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield enabled auto-merge (squash) May 15, 2023 05:00
@MichaelScofield
Copy link
Collaborator

@Fengys123 there are conflicts

@fengys1996 fengys1996 force-pushed the feat/frontend/heartbeat branch from 2dc5e51 to 2645c0a Compare May 15, 2023 08:49
@fengys1996 fengys1996 force-pushed the feat/frontend/heartbeat branch from f5b2cf6 to edcb2ad Compare May 15, 2023 09:42
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelScofield MichaelScofield merged commit 027707d into GreptimeTeam:develop May 15, 2023
@fengys1996 fengys1996 deleted the feat/frontend/heartbeat branch May 15, 2023 09:55
@fengys1996 fengys1996 removed the docs-required This change requires docs update. label May 15, 2023
QuenKar pushed a commit to QuenKar/greptimedb that referenced this pull request May 15, 2023
* feat: support frontend heartbeat

* fix: typo "reponse" -> "response"

* add ut

* enable start heartbeat task

* chore: frontend id is specified by metasrv, not in the frontend startup parameter

* fix typo

* self-cr

* cr

* cr

* cr

* remove unnecessary headers

* use the member id in the header as the node id
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: support frontend heartbeat

* fix: typo "reponse" -> "response"

* add ut

* enable start heartbeat task

* chore: frontend id is specified by metasrv, not in the frontend startup parameter

* fix typo

* self-cr

* cr

* cr

* cr

* remove unnecessary headers

* use the member id in the header as the node id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants