fix: address comments

Signed-off-by: Zhenchi <[email protected]>
GreptimeTeam · Jul 4, 2024 · ce0050d · ce0050d
1 parent 81ea1b6
commit ce0050d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/puffin/src/puffin_manager.rs b/src/puffin/src/puffin_manager.rs
@@ -72,7 +72,7 @@ pub struct PutOptions {
 
 /// The `PuffinReader` trait provides methods for reading blobs and directories from a Puffin file.
 #[async_trait]
-#[auto_impl::auto_impl(Box, Rc, Arc)]
+#[auto_impl::auto_impl(Box, Arc)]
 pub trait PuffinReader {
     type Blob: BlobGuard;
     type Dir: DirGuard;
@@ -92,15 +92,15 @@ pub trait PuffinReader {
 
 /// `BlobGuard` is provided by the `PuffinReader` to access the blob data.
 /// Users should hold the `BlobGuard` until they are done with the blob data.
-#[auto_impl::auto_impl(Box, Rc, Arc)]
+#[auto_impl::auto_impl(Box, Arc)]
 pub trait BlobGuard {
     type Reader: AsyncRead + AsyncSeek + Unpin;
     fn reader(&self) -> BoxFuture<'static, Result<Self::Reader>>;
 }
 
 /// `DirGuard` is provided by the `PuffinReader` to access the directory in the filesystem.
 /// Users should hold the `DirGuard` until they are done with the directory.
-#[auto_impl::auto_impl(Box, Rc, Arc)]
+#[auto_impl::auto_impl(Box, Arc)]
 pub trait DirGuard {
     fn path(&self) -> &PathBuf;
 }
diff --git a/src/puffin/src/puffin_manager/file_accessor.rs b/src/puffin/src/puffin_manager/file_accessor.rs
@@ -19,7 +19,7 @@ use crate::error::Result;
 
 /// `PuffinFileAccessor` is for opening readers and writers for puffin files.
 #[async_trait]
-#[auto_impl::auto_impl(Box, Rc, Arc)]
+#[auto_impl::auto_impl(Box, Arc)]
 pub trait PuffinFileAccessor: Send + Sync + 'static {
     type Reader: AsyncRead + AsyncSeek + Unpin + Send;
     type Writer: AsyncWrite + Unpin + Send;

diff --git a/src/puffin/src/puffin_manager/stager.rs b/src/puffin/src/puffin_manager/stager.rs
@@ -52,7 +52,7 @@ pub trait InitDirFn = Fn(DirWriterProviderRef) -> WriteResult;
 
 /// `Stager` manages the staging area for the puffin files.
 #[async_trait]
-#[auto_impl::auto_impl(Box, Rc, Arc)]
+#[auto_impl::auto_impl(Box, Arc)]
 pub trait Stager: Send + Sync {
     type Blob: BlobGuard;
     type Dir: DirGuard;