Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frontend heartbeat proto #27

Closed

Conversation

fengys1996
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly add frontend heartbeat proto.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#1189
GreptimeTeam/greptimedb#816

@fengys1996 fengys1996 marked this pull request as ready for review April 20, 2023 07:27
@@ -28,6 +28,7 @@ fn main() {
"proto/greptime/v1/health.proto",
"proto/greptime/v1/meta/common.proto",
"proto/greptime/v1/meta/heartbeat.proto",
"proto/greptime/v1/meta/frontend_heartbeat.proto",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this into heartbeat.proto?

@fengys1996 fengys1996 marked this pull request as draft April 20, 2023 10:01
@fengys1996 fengys1996 closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants