extend ShapedOreRecipe along with implementing a fluid ingredient for crafting recipes #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows crafting recipes to actually CHECK for the actual fluid in a bucket. since Forge doesnt account for any of it by itself. Properly implementing container item methods allows for use of drums and quantum tanks to be used along with those recipes, without being consumed
src/main/java/gregtech/common/crafting/GTFluidCraftingIngredient.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/items/metaitem/stats/ItemFluidContainer.java
Outdated
Show resolved
Hide resolved
TechLord22
requested changes
Aug 16, 2022
src/main/java/gregtech/api/block/machines/MachineItemBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/block/machines/MachineItemBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/crafting/GTFluidCraftingIngredient.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/crafting/GTShapelessOreRecipe.java
Outdated
Show resolved
Hide resolved
TechLord22
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows crafting recipes to actually CHECK for the actual fluid in a bucket. since Forge doesnt account for any of it by itself.
Implementation Details
Properly implementing container item methods allows for use of drums and quantum tanks to be used along with those recipes, without being consumed
Outcome
Fixes: #1125
Potential Compatibility Issues
None wishful thinking