Fix multiblock strcuture checking #2247
Merged
+4
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This mixin is used to notify structure changes for multiblock. I added it based on vanilla code before, because gtm was based on multiple platform.
I didn't notice that the forge modifies
LevelChunk
code. They add a new feature (captureBlockSnapshots
) to speed up blockstate updates. However, it will block multiblock strcuture validation checking in some cases.There is no problem when breaking blocks, but nomore checking when placing blocks into structures.
I am surprised that this bug has not had an impact for so long. (Mainly, the act of placing blocks in pattern is barely(never) happens for multiblocks of gtm)
Implementation Details
original mixin injection:
new injection: