Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more interactions + fixes for Lighter #2075

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

JuiceyBeans
Copy link
Contributor

@JuiceyBeans JuiceyBeans commented Oct 1, 2024

What

Brings the lighter upto par with the vanilla Flint and Steel
Also added a tooltip for how to open the Lighter

To do:

  • Stop lighter from trying to light blocks that are already lit

Implementation Details

This PR is built off a ton of janky if conditions. Someone more knowledgeable than me, PLEASE FOR THE LOVE OF GOD take a look at it and tell me if I can make it better
Partly fixes #2071

Outcome

  • Lighter can light candles, extinguished campfires, cake blocks with candles
  • Lighter sets soul fire on top of soul sand and soul soil instead of normal fire
  • Lighter does not consume fuel if interaction fails
  • Lighter does not set fire in janky ways anymore

@JuiceyBeans JuiceyBeans marked this pull request as ready for review October 1, 2024 17:25
@JuiceyBeans JuiceyBeans requested a review from a team as a code owner October 1, 2024 17:25
@screret screret added the type: bugfix general bug fixes label Oct 4, 2024
@screret screret merged commit b312167 into GregTechCEu:1.20.1 Oct 6, 2024
3 of 4 checks passed
@JuiceyBeans JuiceyBeans deleted the beans/lighter-fixes branch October 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighter + shovel issues
2 participants