Tomer-arm #9

tomer-hershman · 2024-08-04T14:32:38Z

No description provided.

src/main/java/training/Robot.java

src/main/java/training/subsystems/Module.java

src/main/java/training/subsystems/RobotArm/ElbowSubsystem.java

src/main/java/training/subsystems/RobotArm/WristConstans.java

src/main/java/training/subsystems/RobotArm/WristSubsystem.java

src/main/java/utils/simulation/FlywheelSimulation.java

src/main/java/utils/simulation/GyroSimulation.java

src/main/java/training/commands/MoveElbowToAngle.java

src/main/java/training/subsystems/RobotArm/ElbowConstants.java

src/main/java/training/subsystems/RobotArm/WristSubsystem.java

src/main/java/utils/DefaultRobotManager.java

src/main/java/training/subsystems/RobotArm/RolerConstens.java

greenblitz4590

IM SORRY
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡿⠿⣿⣿⣭⣦⣭⣭⣍⡙⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡟⢉⡙⠿⠟⣋⣴⣶⣶⣾⣿⣿⣿⣿⣿⣿⣿⣿⣿⣶⣌⠛⢿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡟⣠⡞⡷⠶⠙⣿⣿⣿⣿⣿⣿⣿⣿⡿⠝⡛⠻⣿⣿⣿⣿⣇⠈⢿⣿⣿⣿⣿⠟⡁⠀⠹⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣧⣉⠁⢹⡗⠶⠦⣌⠙⣿⣿⣝⢭⡵⠚⠉⠉⠛⣿⣿⣿⣯⠛⢧⠈⣿⣿⡿⢋⣾⠀⢀⣇⢿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣧⢸⣫⣤⣤⣄⣸⣿⣿⣿⣤⣶⣶⣶⣾⣶⣬⣿⣿⣿⣆⠈⠀⠈⢩⡶⠟⢋⣁⣈⣁⣾⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡿⢸⣿⣿⣿⢿⣿⣿⣿⣿⢻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣧⣽⣇⠀⣴⣾⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠇⣿⣿⣿⠏⠘⠻⠛⠉⠻⣦⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠀⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⢸⣿⣿⣿⢠⣶⣤⣤⣶⣶⣾⣧⠹⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣧⠈⠉⠉⡉⠉⠛⠿⠿⠿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣸⣿⣿⢣⡿⠛⠛⠛⠛⠿⣿⣿⣧⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣧⣰⣶⣦⡀⠂⠀⠀⠠
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡏⣿⣿⣿⣇⠀⢄⣷⣷⣠⣈⣻⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡿⠟⠻⢿⣿⡟⠂⠀⠀⢀
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡇⣿⣿⣿⣿⣿⣯⣙⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⢋⣴⣿⣿⠶⠍⠃⠀⣤⡈⢉
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣷⢸⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⢸⣿⡿⢡⣾⣿⣦⣼⣿⣷⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠊⣿⡙⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣄⠻⠇⢸⣿⣿⣿⡿⠇⠙⢿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡿⣿⣿⠁⡄⢻⣧⠹⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡟⢡⣴⣦⡄⠉⢉⡁⠀⠐⠣⠄
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠋⢱⠟⡁⠀⠁⠈⢿⣧⣙⢿⣿⣺⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠋⣠⣿⣿⠟⠀⠀⠀⠀⠀⠰⠂⠘
⣿⡟⣿⣿⣿⣿⣿⣿⣿⣿⣿⠃⠀⢠⣾⡇⠾⠀⠀⠈⣿⡿⢿⡻⠿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⠟⣡⣾⣿⡿⢃⠀⠀⠀⢀⣀⣀⡀⢼⠀
⣿⠁⣿⣿⡿⣫⣾⣿⢏⣿⠏⠀⣰⣿⣿⠃⠠⠀⠀⠀⠈⢿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡿⢛⣡⣾⣿⣿⠏⣠⡆⠀⠀⣴⣿⣿⣿⣿⣦⠀
⣼⠀⠟⣡⣾⣿⣿⡏⣼⡏⢈⢠⣿⣿⣿⡁⠀⠀⠀⣦⠀⠀⠉⠉⢉⣙⠻⠿⣿⣿⣿⣥⣶⣿⣿⠿⠛⣁⡶⠈⠀⠀⢰⣿⣿⣿⣿⣿⣿⡇
⣟⢠⡞⣿⡇⣿⠟⣼⡿⢣⡎⣾⣿⣿⣿⡇⠘⠀⠈⠛⠀⠀⠀⠀⠈⠛⠿⡅⢠⣈⡛⢛⣿⣽⣷⣶⣿⠛⠀⠀⠀⠀⠀⠀⠙⠿⣿⠿⢿⣿
⣿⢸⡇⢫⠀⠿⢠⡿⢁⡞⣸⣿⣿⣿⣿⣿⡀⠀⠀⠂⠀⠀⠀⠀⠀⠀⠀⠀⠀⠉⠫⢣⣾⣾⣿⣿⠇⠀⠀⠀⠀⠀⠀⠀⠀⠀⠐⢶⣿⣿
⣱⡘⢁⣿⠀⢀⣿⢁⡮⢰⣿⣿⣿⣿⣿⣿⣧⠀⠀⠀⠀⠀⠀⠀⠀⡀⠀⠀⡀⠀⠀⠀⢀⡁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢹⣿

src/main/java/training/commands/elbow/MoveElbowToAngle.java

src/main/java/training/subsystems/RobotArm/Roller.java

src/main/java/training/subsystems/RobotArm/WristSubsystem.java

Sh-Pe

ahhhh

src/main/java/training/RobotTypes.java

src/main/java/training/TrainingRobotManager.java

src/main/java/training/commands/elbow/MoveElbowToAngle.java

src/main/java/training/commands/roller/MoveRollerAtSpeed.java

src/main/java/training/subsystems/RobotArm/elbow/IElbow.java

src/main/java/training/subsystems/RobotArm/roller/Roller.java

src/main/java/training/subsystems/RobotArm/wrist/IWrist.java

Sh-Pe · 2024-08-21T16:17:05Z

cat car

Sh-Pe · 2024-08-24T08:14:28Z

Consider running .\graldew spotlessApply on the main directory. This will pass you the formatting test (also make a separate commit for that).

src/main/java/training/subsystems/RobotArm/elbow/ElbowSimulation.java

src/main/java/training/RobotTypes.java

src/main/java/training/TrainingRobotManager.java

src/main/java/training/commands/wrist/MoveWristToAngle.java

src/main/java/training/subsystems/RobotArm/roller/IRoller.java

src/main/java/training/subsystems/RobotArm/roller/RollerNEO.java

src/main/java/training/subsystems/RobotArm/roller/IRoller.java

src/main/java/training/subsystems/RobotArm/wrist/WristNEO.java

src/main/java/training/GeneralConstants.java

src/main/java/training/commands/elbow/MoveElbowToAngle.java

src/main/java/training/subsystems/RobotArm/elbow/Elbow.java

src/main/java/training/subsystems/RobotArm/elbow/ElbowFactory.java

src/main/java/training/subsystems/RobotArm/roller/Roller.java

src/main/java/training/subsystems/RobotArm/roller/RollerConstants.java

src/main/java/training/subsystems/RobotArm/roller/RollerNEO.java

src/main/java/training/subsystems/RobotArm/wrist/IWrist.java

src/main/java/training/commands/roller/MoveRollerAtSpeed.java

src/main/java/training/commands/wrist/MoveWristToAngle.java

src/main/java/training/commands/elbow/MoveElbowToAngle.java

src/main/java/training/subsystems/RobotArm/elbow/ElbowSimulation.java

GilStein1

יפה מאוד

GilStein1 · 2024-08-25T16:44:57Z

src/main/java/training/commands/roller/MoveRollerAtSpeed.java

+public class MoveRollerAtSpeed extends Command {
+
+	private Roller roller;
+	private Rotation2d velocity;


GilStein1 · 2024-08-25T16:45:38Z

src/main/java/training/commands/roller/MoveRollerAtSpeed.java

+	private Roller roller;
+	private Rotation2d velocity;
+
+	public MoveRollerAtSpeed(Rotation2d velocity) {


same, double and not rotation2d

GilStein1 · 2024-08-25T16:46:46Z

src/main/java/training/commands/roller/MoveRollerAtSpeed.java

+	}
+
+	public void initialize() {
+		Roller.getInstance().moveAtSpeed(velocity.getDegrees());


.moveAtSpeed(velocity) change velocity to a double representing the rotation

GilStein1 · 2024-08-25T16:49:26Z

src/main/java/training/subsystems/RobotArm/roller/Roller.java

+	public boolean isAtSpeed(Rotation2d velocity) {
+		return (Math.abs(getVelocity().minus(velocity).getDegrees()) <= RollerConstants.TOLERANCE.getDegrees());
+	}


maybe velocity should be a double

GilStein1 · 2024-08-25T16:52:38Z

src/main/java/training/subsystems/RobotArm/elbow/Elbow.java

+		if (instance == null)
+			instance = new Elbow();


סוגריים מסולסלים בבקשה

GilStein1 · 2024-08-25T16:53:17Z

src/main/java/training/subsystems/RobotArm/elbow/Elbow.java

+	public Rotation2d getVelocity() {
+		return inputs.velocity;
+	}


I think velocity should be a double

GilStein1 · 2024-08-25T16:58:34Z

src/main/java/training/subsystems/RobotArm/roller/Roller.java

+		motor.getPIDController().setReference(velocity, CANSparkBase.ControlType.kVelocity, RollerConstants.PID_SLOT);
+	}
+
+


רווח כפול

GilStein1 · 2024-08-25T16:58:56Z

src/main/java/training/subsystems/RobotArm/roller/Roller.java

+		return Rotation2d.fromDegrees(motor.getEncoder().getVelocity());
+	}
+
+


רווח כפול

itamaroryan and others added 9 commits July 17, 2024 18:53

Yoni - added joyysticks

f8c5528

tomer and guy - robot

ed95af0

yotam and tomer - PID

23dd4a6

guy and tomer robot code

12cd07f

guy and tomer robot code

e0629d5

guy and tomer robot arm

6b1ef28

tomer and guy sarted PID on arm

dc34dc6

Tomer- finished PID Wrist and Roller

d1a1c59

tomer-finished

012fdf1

bossyshrimp68 requested changes Aug 4, 2024

View reviewed changes

YHerm assigned tomer-hershman Aug 7, 2024

tomer-hershman added 6 commits August 7, 2024 16:22

cr 1

0746e76

cr 1

37b8586

cr 1

7db3775

cr 1

da02665

hilel and tomer spotless

421e234

tomer - started moving stuf

0b0b3ad

YoniKiriaty changed the base branch from master to on-robot August 7, 2024 20:38

YoniKiriaty reviewed Aug 7, 2024

View reviewed changes

tomer-finised comends(or at least I think so)

7c7b3ab

greenblitz4590 requested changes Aug 18, 2024

View reviewed changes

tomer-hershman added 7 commits August 21, 2024 09:50

tomer- worct on the hole arm manely elbow

3e154de

tomer- warked on the elbow

97414be

tomer- warked on factory

a766980

tomer- warked on factory

205a997

tomer- warked on factory

4f8dfa9

tomer- warked on factory

e96b5ef

tomer- warked on factory

90b6b86

Sh-Pe reviewed Aug 21, 2024

View reviewed changes

tomer-finised shahar cr

09ff21b

tomer-hershman added 3 commits August 24, 2024 19:38

tomer-finished elbow simulation

a512ee8

tomer-finished elbow simulation

5f9a33b

tomer-finished elbow simulation

0355a62

drorta requested changes Aug 25, 2024

View reviewed changes

src/main/java/training/subsystems/RobotArm/elbow/ElbowSimulation.java Outdated Show resolved Hide resolved

rtomer-request approval cr

ce86a66

YoniKiriaty reviewed Aug 25, 2024

View reviewed changes

rtomer-request approval cr

63a7ddf

YoniKiriaty reviewed Aug 25, 2024

View reviewed changes

rtomer-request approval cr

d982715

YoniKiriaty reviewed Aug 25, 2024

View reviewed changes

src/main/java/training/commands/roller/MoveRollerAtSpeed.java Outdated Show resolved Hide resolved

src/main/java/training/commands/wrist/MoveWristToAngle.java Outdated Show resolved Hide resolved

src/main/java/training/commands/elbow/MoveElbowToAngle.java Show resolved Hide resolved

tomer-hershman added 2 commits August 25, 2024 19:05

rtomer-request approval cr

ffdf1b2

rtomer-request approval cr

3776f75

YoniKiriaty reviewed Aug 25, 2024

View reviewed changes

src/main/java/training/subsystems/RobotArm/elbow/ElbowSimulation.java Outdated Show resolved Hide resolved

rtomer-request approval cr

ead3740

YoniKiriaty approved these changes Aug 25, 2024

View reviewed changes

GilStein1 reviewed Aug 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tomer-arm #9

Tomer-arm #9

tomer-hershman commented Aug 4, 2024

greenblitz4590 left a comment •

edited

Loading

Sh-Pe left a comment

Sh-Pe commented Aug 21, 2024

Sh-Pe commented Aug 24, 2024

GilStein1 left a comment

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

GilStein1 Aug 25, 2024

		motor.getPIDController().setReference(velocity, CANSparkBase.ControlType.kVelocity, RollerConstants.PID_SLOT);
		}

		return Rotation2d.fromDegrees(motor.getEncoder().getVelocity());
		}

Tomer-arm #9

Are you sure you want to change the base?

Tomer-arm #9

Conversation

tomer-hershman commented Aug 4, 2024

greenblitz4590 left a comment • edited Loading

Choose a reason for hiding this comment

Sh-Pe left a comment

Choose a reason for hiding this comment

Sh-Pe commented Aug 21, 2024

Sh-Pe commented Aug 24, 2024

GilStein1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greenblitz4590 left a comment •

edited

Loading