Yotam- make elbow which works for both simulation and real, robot typ…

…e constant, ElbowFactory

src/main/java/subsystems/elbow/Elbow.java

@@ -0,0 +1,32 @@
+package subsystems.elbow;
+
+import edu.wpi.first.math.geometry.Rotation2d;
+
+public class Elbow implements IElbow {
+
+    private IElbow iElbow;
+
+    public Elbow(){
+        iElbow =Factory.create();
+    }
+
+    @Override
+    public Rotation2d getAngle() {
+        return iElbow.getAngle();
+    }
+
+    @Override
+    public double getRPMVelocity() {
+        return iElbow.getRPMVelocity();
+    }
+
+    @Override
+    public void setPower(double power) {
+        iElbow.setPower(power);
+    }
+
+    @Override
+    public void goToPosition(Rotation2d position) {
+        iElbow.goToPosition(position);
+    }
+}

src/main/java/subsystems/elbow/Factory.java

@@ -0,0 +1,16 @@
+package subsystems.elbow;
+
+import subsystems.elbow.neoElbow.NeoElbow;
+import subsystems.elbow.simulationElbow.SimulationElbow;
+import training.Robot;
+
+public class Factory {
+
+    public static IElbow create(){
+        return switch (Robot.ROBOT_TYPE){
+            case REAL -> new NeoElbow();
+            case SIMULATION -> new SimulationElbow();
+        };
+    }
+
+}

src/main/java/subsystems/elbow/neoElbow/NeoElbow.java

@@ -9,23 +9,15 @@
 
 public class NeoElbow extends GBSubsystem implements IElbow {
 
-	private static NeoElbow instance;
 	private static CANSparkMax motor;
 
-	private NeoElbow() {
+	public NeoElbow() {
 		motor = new CANSparkMax(NeoElbowConstants.MOTOR_ID, RobotConstants.MOTOR_BRUSHLESS_TYPE);
 		motor.getPIDController().setP(ElbowConstants.KP);
 		motor.getPIDController().setI(ElbowConstants.KI);
 		motor.getPIDController().setD(ElbowConstants.KD);
 	}
 
-	public static NeoElbow getInstance() {
-		if (instance == null) {
-			instance = new NeoElbow();
-		}
-		return instance;
-	}
-
 	public Rotation2d getAngle() {
 		return Rotation2d.fromRotations(motor.getEncoder().getPosition() % 1);
 	}

src/main/java/subsystems/elbow/simulationElbow/SimulationElbow.java

@@ -10,11 +10,10 @@
 
 public class SimulationElbow implements IElbow {
 
-	private static SimulationElbow instance;
 	private final SingleJointedArmSim motor;
 	private final PIDController controller;
 
-	private SimulationElbow() {
+	public SimulationElbow() {
 		this.motor = new SingleJointedArmSim(
 			DCMotor.getFalcon500(SimulationElbowConstants.NUMBER_OF_MOTORS),
 			SimulationElbowConstants.GEAR_RATIO,
@@ -28,13 +27,6 @@ private SimulationElbow() {
 		this.controller = new PIDController(ElbowConstants.KP, ElbowConstants.KI, ElbowConstants.KD);
 	}
 
-	public SimulationElbow getInstance() {
-		if (instance == null) {
-			instance = new SimulationElbow();
-		}
-		return instance;
-	}
-
 	@Override
 	public Rotation2d getAngle() {
 		return Rotation2d.fromRadians(motor.getAngleRads());

src/main/java/training/Robot.java

@@ -6,6 +6,14 @@
 
 public class Robot {
 
+	public enum RobotType{
+		SIMULATION,
+		REAL
+	}
+
+	public static final RobotType ROBOT_TYPE = RobotType.REAL;
+
+
 	// Enter your subsystems...
 	private final NeoElbow elbow;
 	private final Wrist wrist;