Tailwind (should merge after cleanup) #18

YoniKiriaty · 2024-12-12T16:49:02Z

closes #23

application/src/components/SureButton.tsx

YoniKiriaty · 2024-12-12T17:05:26Z

application/src/scouter/ScoutingTab.tsx

+              <motion.div
+                initial={{ scale: 0 }}
+                animate={{ scale: 1 }}
+                className="flex gap-2"
+              >
+                {currentSectionNumber !== 0 && (
+                  <button
+                    type="button"
+                    onClick={() => setSectionNumber(currentSectionNumber - 1)}
+                    className="btn btn-secondary flex items-center gap-2"
+                  >
+                    <ArrowLeft className="w-4 h-4" />
+                    Previous
+                  </button>
+                )}
+                {currentSectionNumber !== sections.length - 1 && (
+                  <button
+                    type="button"
+                    onClick={() => setSectionNumber(currentSectionNumber + 1)}
+                    className="btn btn-primary flex items-center gap-2"
+                  >
+                    Next
+                    <ArrowRight className="w-4 h-4" />
+                  </button>
+                )}
+              </motion.div>


consider moving this to a variable or different component, currently it is way too nested.

YoniKiriaty · 2024-12-12T17:13:42Z

application/src/components/SureButton.tsx

+        {areYouSure ? (
+          <motion.div
+            initial={{ opacity: 0, scale: 0.95 }}
+            animate={{ opacity: 1, scale: 1 }}
+            exit={{ opacity: 0, scale: 0.95 }}
+            className="absolute bottom-full mb-2 right-0 bg-white rounded-lg shadow-lg p-4 min-w-[200px] dark:bg-dark-card dark:border dark:border-dark-border"
+          >
+            <div className="flex items-center gap-2 text-amber-600 mb-3 dark:text-amber-500">
+              <AlertTriangle className="w-5 h-5" />
+              <span className="font-medium dark:text-dark-text">Are you sure?</span>
+            </div>
+            <div className="flex justify-end gap-2">
+              <button
+                type="button"
+                onClick={() => setAreYouSure(false)}
+                className="btn btn-secondary flex items-center gap-2"
+              >
+                <X className="w-4 h-4" />
+                No
+              </button>
+              <button
+                type="button"
+                onClick={onClick}
+                className="btn btn-primary flex items-center gap-2"
+              >
+                <Check className="w-4 h-4" />
+                Yes
+              </button>
+            </div>
+          </motion.div>
+        ) : null}


Suggested change

{areYouSure ? (

<motion.div

initial={{ opacity: 0, scale: 0.95 }}

animate={{ opacity: 1, scale: 1 }}

exit={{ opacity: 0, scale: 0.95 }}

className="absolute bottom-full mb-2 right-0 bg-white rounded-lg shadow-lg p-4 min-w-[200px] dark:bg-dark-card dark:border dark:border-dark-border"

>

<div className="flex items-center gap-2 text-amber-600 mb-3 dark:text-amber-500">

<AlertTriangle className="w-5 h-5" />

<span className="font-medium dark:text-dark-text">Are you sure?</span>

</div>

<div className="flex justify-end gap-2">

<button

type="button"

onClick={() => setAreYouSure(false)}

className="btn btn-secondary flex items-center gap-2"

>

<X className="w-4 h-4" />

No

</button>

<button

type="button"

onClick={onClick}

className="btn btn-primary flex items-center gap-2"

>

<Check className="w-4 h-4" />

Yes

</button>

</div>

</motion.div>

) : null}

{areYouSure && (

<motion.div

initial={{ opacity: 0, scale: 0.95 }}

animate={{ opacity: 1, scale: 1 }}

exit={{ opacity: 0, scale: 0.95 }}

className="absolute bottom-full mb-2 right-0 bg-white rounded-lg shadow-lg p-4 min-w-[200px] dark:bg-dark-card dark:border dark:border-dark-border"

>

<div className="flex items-center gap-2 text-amber-600 mb-3 dark:text-amber-500">

<AlertTriangle className="w-5 h-5" />

<span className="font-medium dark:text-dark-text">Are you sure?</span>

</div>

<div className="flex justify-end gap-2">

<button

type="button"

onClick={() => setAreYouSure(false)}

className="btn btn-secondary flex items-center gap-2"

>

<X className="w-4 h-4" />

No

</button>

<button

type="button"

onClick={onClick}

className="btn btn-primary flex items-center gap-2"

>

<Check className="w-4 h-4" />

Yes

</button>

</div>

</motion.div>

) }

DONT COMMIT SUGGESTION

YoniKiriaty · 2024-12-12T17:16:42Z

application/src/scouter/MatchList.tsx

+              <motion.div
+                key={index}
+                initial={{ opacity: 0, y: 20 }}
+                animate={{ opacity: 1, y: 0 }}
+                exit={{ opacity: 0, y: -20 }}
+                className="mb-4"
+              >
+                <Collapsible
+                  trigger={
+                    <div className="flex items-center justify-between p-4 bg-gray-50 rounded-lg hover:bg-gray-100 transition-colors cursor-pointer dark:bg-dark-card dark:hover:bg-gray-800">
+                      <span className="text-gray-900 font-medium dark:text-dark-text">
+                        {match["Team Number"]} {matchName} {match[matchName]}
+                      </span>
+                      <ChevronDown className="w-5 h-5 text-gray-500 dark:text-dark-text-secondary" />
+                    </div>
+                  }
+                  triggerClassName="w-full"
+                  transitionTime={200}
+                >
+                  <div className="p-4 space-y-4 dark:bg-dark-card dark:border-t dark:border-dark-border">
+                    <div className="flex justify-center">
+                      <QRCodeGenerator text={JSON.stringify(match)} />
+                    </div>
+                    <div className="flex justify-center gap-4">
+                      <button
+                        type="button"
+                        onClick={() => removeMatch(match?.[matchName], index)}
+                        className="btn btn-secondary flex items-center gap-2"
+                      >
+                        <Trash2 className="w-4 h-4" />
+                        Delete
+                      </button>
+                      <button
+                        type="button"
+                        onClick={() => sendMatch(match, index)}
+                        className="btn btn-primary flex items-center gap-2"
+                      >
+                        <Send className="w-4 h-4" />
+                        Send
+                      </button>
+                    </div>
+                  </div>
+                </Collapsible>
+              </motion.div>


consider moving this to a seperate component

greenblitz and others added 14 commits November 24, 2024 19:05

Yoni - sure

0066d09

Yoni - session lol

842ba45

Yoni - autonomus no more

532a749

Yoni - session

8356ee0

Yoni - folder shish

edf9968

Yoni - no duality of man"

00bf8e4

Yoni - cleanup strategy

c98e7c2

Yoni - better Queries

5d15b1b

Yoni - better Queries this time actually

9354624

Yoni - fixed storage

15dd65f

Yoni - better type

7750b8d

Yoni - imports and such

a3b3bb1

Yoni - nice

fdd24c7

Yuval and Yoni - added all tailwind stuff

83ce692

YoniKiriaty assigned CoolGame8 Dec 12, 2024

YoniKiriaty commented Dec 12, 2024

View reviewed changes

YoniKiriaty added New Feature New feature or request Frontend Something that changes a significant part of the frontened Improvement Improving something about the code or the user experience labels Dec 18, 2024

Base automatically changed from cleanup-lol to master December 19, 2024 08:29

YoniKiriaty closed this Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tailwind (should merge after cleanup) #18

Tailwind (should merge after cleanup) #18

YoniKiriaty commented Dec 12, 2024 •

edited

Loading

YoniKiriaty Dec 12, 2024

YoniKiriaty Dec 12, 2024

YoniKiriaty Dec 12, 2024

Tailwind (should merge after cleanup) #18

Tailwind (should merge after cleanup) #18

Conversation

YoniKiriaty commented Dec 12, 2024 • edited Loading

YoniKiriaty Dec 12, 2024

Choose a reason for hiding this comment

YoniKiriaty Dec 12, 2024

Choose a reason for hiding this comment

YoniKiriaty Dec 12, 2024

Choose a reason for hiding this comment

YoniKiriaty commented Dec 12, 2024 •

edited

Loading