hotfix-break-coast switch -> master #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamRosenberg08
requested changes
Sep 23, 2023
src/main/java/edu/greenblitz/utils/breakCoastToggle/BreakCoastSwitch.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/greenblitz/utils/breakCoastToggle/BreakCoastSwitch.java
Outdated
Show resolved
Hide resolved
greenblitz4590
commented
Nov 29, 2023
There was a problem hiding this comment.
Hmmm, consider adding this to the .gitignore file
| @@ -112,13 +112,16 @@ public void robotPeriodic() { | |||
| @Override | |||
| public void disabledInit() { | |||
| CommandScheduler.getInstance().cancelAll(); | |||
|
|
|||
| BreakCoastSwitch.getInstance().setIsDisabled(true); | |||
There was a problem hiding this comment.
Consider changing the name to something clearer, such as
Suggested change
| BreakCoastSwitch.getInstance().setIsDisabled(true); | |
| BreakCoastSwitch.getInstance().setDisabled(true); |
In any case, couldn't you just get this from the driver station?
| } | ||
|
|
||
|
|
||
|
|
||
| @Override | ||
| public void teleopInit() { | ||
| CommandScheduler.getInstance().cancelAll(); | ||
| BreakCoastSwitch.getInstance().setIsDisabled(false); |
|
|
||
| private static BreakCoastSwitch instance; | ||
|
|
||
| private boolean isDisabled; |
There was a problem hiding this comment.
What is the reason for this? 🤔
| @@ -26,7 +35,9 @@ public static BreakCoastSwitch getInstance() { | |||
| private BreakCoastSwitch(int id) { | |||
| switchInput = new DigitalInput(id); | |||
| subsystems = new HashMap<>(); | |||
| this.switchPressCount = 0; | |||
| this.switchPressCount = 1; | |||
| debouncer = new Debouncer(0.1); | |||
There was a problem hiding this comment.
What is 0.1 in this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.