-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO submission editorials #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2022
atg-abhishek
requested changes
Oct 13, 2022
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md
Outdated
Show resolved
Hide resolved
atg-abhishek
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by WG
29 tasks
seanmcilroy29
added a commit
that referenced
this pull request
Nov 1, 2022
* Added template for case studies * Update Software_Carbon_Intensity/case_study_template.md Co-authored-by: Asim Hussain <[email protected]> * Update Software_Carbon_Intensity/case_study_template.md Co-authored-by: Asim Hussain <[email protected]> * Update Software_Carbon_Intensity/case_study_template.md Co-authored-by: Asim Hussain <[email protected]> * Implement proposed reporting requirements from discussion 103 (#123) * Add first pass of text * Add reference to RFC4122 * Added description of valid requirements * Added first examples * Grammar review * Remove JSON * Move table structure to appendix * Remove reporting process * Changed software boundary reporting requirements * Removed other references to reports * updated URLs * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md Co-authored-by: Asim Hussain <[email protected]> * Update Software_Carbon_Intensity/Appendix_A_Further_Information_on_Reporting_Requirements.md Co-authored-by: Asim Hussain <[email protected]> * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md Co-authored-by: Asim Hussain <[email protected]> * Changed baseline preset text * Made software version mandatory * Removed the requirement to report C and R baseline comment Co-authored-by: Asim Hussain <[email protected]> Co-authored-by: Abhishek Gupta <[email protected]> * Market instruments and grid interconnected infrastructure discussion * Typos * Update Software_Carbon_Intensity_Specification.md 1. The software-boundary was not linked correctly. 2. Readability - LCA definition was defined later, moved it to the first reference. * Update Software_Carbon_Intensity_Specification.md 1. Functional Unit was not linked properly * Update Software_Carbon_Intensity_Specification.md Qualifying that the elements in the SCI equation scale by the same functional unit R * adding units to 'M' and reformatting for consistency (#231) * Add files via upload * Update issue templates * adding units - units added for embodied emissions - moved units to the bottom of each section - reformatted for consistency Co-authored-by: Abhishek Gupta <[email protected]> Co-authored-by: Sean Mcilroy <[email protected]> Co-authored-by: Sean Mcilroy <[email protected]> Co-authored-by: Henry-WattTime <[email protected]> * Eshoppen case study initial draft * Rename eshoppen to eshoppen.md * Added definition on how software causes emissions * changed wording to software systems * Update eshoppen.md Included the changes for the Energy and Embodied emissions values for the database server. * Update Software_Carbon_Intensity.md Updated the Software Carbon Intensity Standard to include guidance on taking into account data center energy efficiency in the Software Boundary section * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md Space added Co-authored-by: Abhishek Gupta <[email protected]> * Added context for SCI reduction for software roles Added context for SCI reduction for software roles * Procedure Flow Updates 1. 'scale' should be first step in the process, as it's the key measure of success 2. 'what' is a bit misleading, and is best defined as a boundary -> 'bound' is a good verb 3. 'how' is a step that best follows the boundary step -> 'bound' is a verb * Reverse list order WG approved * Text edits to introduction * Focus on elimination/abatement (#290) * Changed wording to highlight elimination * Change exclusions WG Approved * Add space WG approved * Restore dev action sentence WG Approved Co-authored-by: Henry-WattTime <[email protected]> * Composable SCI Scores * Update Software_Carbon_Intensity_Specification.md Updated as per WG feedback * add space WG Approved * Spelling correction in the introduction section * Be explicit regarding only eliminations We've made it explicit in `I` but I believe we also need to make it explicit in `M`. * Copywriter updates * Update Software_Carbon_Intensity_Specification.md * Update README.md a few minor improvements to wording on the readme, including a typo or two... * Update README.md WG Approved. Co-authored-by: Abhishek Gupta <[email protected]> * Apply suggestions from code review WG Approved Co-authored-by: Abhishek Gupta <[email protected]> * Update Software_Carbon_Intensity_Specification.md Some suggested changes to the 'scope' section, based on my first impressions/first read... * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md WG approved * Update Software_Carbon_Intensity_Specification.md (#298) * Update Software_Carbon_Intensity_Specification.md A few relatively minor suggested updates to the Introduction * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md WG Approved. * Apply suggestions from code review WG Approved Co-authored-by: Abhishek Gupta <[email protected]> Co-authored-by: Henry-WattTime <[email protected]> Co-authored-by: Abhishek Gupta <[email protected]> * Update Software_Carbon_Intensity_Specification.md (#299) small change to the 'Software Sustainability Actions' section. I'd like to suggest we also rename 'Energy Efficiency' to 'Software Efficiency', but we should discuss that one and I can explain my thinking... Co-authored-by: Henry-WattTime <[email protected]> * Update Software_Carbon_Intensity_Specification.md (#300) minor suggested tweaks to the Procedure section, that might improve readability Co-authored-by: Henry-WattTime <[email protected]> * Re-order formula for clarity (#304) * Re-order formula for clarity Reversed hierarchy from complex formula at the top and simple formula at the bottom. Now you build knowledge as you go down: SCI = C / R -> SCI = (O + M)/R -> SCI = (O formula + M formula)/R. * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md WG removed change. * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md WG Approved * Update issue templates * Update issue templates * Update issue templates * Refine definitions of O & M * Removed table from the definitions section Removed definitions from the document and added link to the GSF dictionary where definitions for the terms used in the document are / will be stored * Removed abbreviations section Removed the abbreviations section and merged it into the definitions section with a reference to the GSF dictionary for both * Reorder Embodied Emissions Calculation * Change Reporting Requirement in Procedure Instead of requiring reporting (which we have not yet developed requirements for) just indicate that reporting should be done. * Updated version note * ISO submission editorials (#331) * Removed Versions section * Replace RFC2119 key words with ISO notation * Revise Scope * Revised/moved Introduction * Added Terms and definitions section * Revised sw sustainability thru location-based * Revised Embodied Emissions & Functional unit * Revised s/w boundary thru comparing an SCI * Revised Code Characteristics thru end; added Bibliography * Apply minor tweaks * Update Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md * Apply suggestions from code review Co-authored-by: Rex Jaeschke <[email protected]> Co-authored-by: Abhishek Gupta <[email protected]> Co-authored-by: Abhishek Gupta <[email protected]> Co-authored-by: Abhishek Gupta <[email protected]> Co-authored-by: Asim Hussain <[email protected]> Co-authored-by: Chris Lloyd-Jones <[email protected]> Co-authored-by: Henry-WattTime <[email protected]> Co-authored-by: Navveen Balani <[email protected]> Co-authored-by: Srinivasan <[email protected]> Co-authored-by: Will Buchanan <[email protected]> Co-authored-by: Sean Mcilroy <[email protected]> Co-authored-by: GadhuNTTDATA <[email protected]> Co-authored-by: Ben Logan <[email protected]> Co-authored-by: Rex Jaeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial submissions to conform with the ISO submission
These changes are format and not content