Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use-circuit-breaker.md #261

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update use-circuit-breaker.md #261

merged 1 commit into from
Oct 6, 2023

Conversation

russelltrow
Copy link
Member

Added required description field & publish date to "cloud/use-circuit-breaker" pattern

Added description & publish date to "cloud/use-circuit-breaker" pattern

Signed-off-by: Russell Trow <[email protected]>
@russelltrow russelltrow self-assigned this Sep 28, 2023
@russelltrow russelltrow added the bug Something isn't working label Sep 28, 2023
@markus-gsf-seidl
Copy link
Contributor

Is the description field actually used anywhere? It's also not filled out in every pattern on the main branch.

Copy link
Contributor

@markus-gsf-seidl markus-gsf-seidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russelltrow
Copy link
Member Author

Is the description field actually used anywhere? It's also not filled out in every pattern on the main branch.

It is used in the <head> Open Graph Meta tags:

e.g. <meta data-rh="true" name="twitter:description" content="An online open-source database of green software patterns reviewed and curated by the Green Software Foundation">

It isn't a mandatory field but if the default value isn't changed in the template it caused the site build to fail.

@russelltrow russelltrow merged commit abf154b into main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants