Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Asynchronous Calls instead of sync when doing Network calls #76 #209

Conversation

markus-gsf-seidl
Copy link
Contributor

@markus-gsf-seidl markus-gsf-seidl commented Jan 17, 2023

Conversion of #76 as the owner seems to have problems with PRs to this repository.

Added the flavour of #108 and made it a cloud pattern, added consideration to cover both.

@markus-gsf-seidl markus-gsf-seidl added CLOUD CLOUD Patterns proposed pattern An idea for a new pattern to submit initial review labels Mar 8, 2023
@greenhsu123 greenhsu123 requested a review from aoifefitton March 14, 2023 14:56
@aoifefitton
Copy link

For initial review:
@srini1978
A few phrasing suggestions:
In the "Solution" section consider changing "lesser energy consumed" to "reducing energy consumption".
In the "SCI impact" section consider changing "hence energy consumed is reduced" to "reducing energy consumption" and also to add full stops to both the E & M sentences.
In the "Assumptions" section a full stop is to be added also.

Otherwise, content/structure looks good.

The referenced existing Cloud Pattern "Optimize average CPU utilization" seems to act as a parent pattern to this one, however I think this pattern may be better suited for the Web section, what do you think @markus-ntt-seidl

Markus Seidl added 2 commits March 16, 2023 15:33
I, Markus Seidl <[email protected]>, hereby add my Signed-off-by to this commit: 374d867
I, Markus Seidl <[email protected]>, hereby add my Signed-off-by to this commit: 6e11cf0
I, Markus Seidl <[email protected]>, hereby add my Signed-off-by to this commit: 76a52d8
I, Markus Seidl <[email protected]>, hereby add my Signed-off-by to this commit: 9a1c334

Signed-off-by: Markus Seidl <[email protected]>
@markus-gsf-seidl
Copy link
Contributor Author

Thanks for your feedback.

Here is my reasoning why I think it's cloud:

Web is by default async and it's hard (if not impossible) to do synchronous calls in the browser.
Whereas in the backend/cloud synchronous patterns are the default - where async would be better. I see a lot of devs doing something like this:

var resultA = callServiceA();
// do something with A
var resultB = callServiceB();
// do something with B (only)

Without any dependencies between A and B this can be easily done async.

One thing that happens in web often is call chaining ( the result-promise of service A would then call service B if A is done). For this there is already a pattern in web to improve this (Avoid chaining critical requests).

@aoifefitton
Copy link

@markus-ntt-seidl ok thank you for explaining - Cloud sounds good.

@greenhsu123
Copy link
Contributor

Completed SME review. The content looks good, thanks!

@russelltrow russelltrow changed the base branch from main to dev October 11, 2023 12:19
@russelltrow russelltrow merged commit 95de7bb into Green-Software-Foundation:dev Oct 19, 2023
@russelltrow russelltrow added Technical Writer Review Consistency review from the technical writer and removed Ready to Merge labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOUD CLOUD Patterns proposed pattern An idea for a new pattern to submit Technical Writer Review Consistency review from the technical writer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants