Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregation method #943

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Fix aggregation method #943

merged 9 commits into from
Aug 8, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Aug 7, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@manushak manushak self-assigned this Aug 7, 2024
@manushak manushak linked an issue Aug 7, 2024 that may be closed by this pull request
Fix aggregation config #941
Closed
4 tasks
jmcook1186
jmcook1186 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit eef1183 into main Aug 8, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the fix-aggregation-method branch August 8, 2024 04:56
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix aggregation config
3 participants
@manushak @narekhovhannisyan @jmcook1186