Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time-converter plugin #925

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Add time-converter plugin #925

merged 8 commits into from
Aug 9, 2024
+403 −13

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@manushak manushak self-assigned this Jul 29, 2024
@manushak manushak linked an issue Jul 29, 2024 that may be closed by this pull request
Create time conversion plugin #910
Closed
7 tasks
@manushak @narekhovhannisyan
Update src/if-run/builtins/time-converter/README.md
55f6b83 
Co-authored-by: Narek Hovhannisyan <[email protected]>
Signed-off-by: Manushak Keramyan <[email protected]>
jmcook1186
jmcook1186 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected - nice work @manushak

@jmcook1186 jmcook1186 merged commit b0933d7 into main Aug 9, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the time-converter-plugin branch August 9, 2024 08:48
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create time conversion plugin
3 participants
@manushak @narekhovhannisyan @jmcook1186