Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex multiple matches #901

Conversation

mouhamadalmounayar
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • The extractMatching function has been enhanced to support multiple matches using regular expressions. Previously, the function returned the first single match within the input parameter. The updated function now allows for capturing all matches if the /g flag is used, and concatenating them into a single string separated by spaces.

@mouhamadalmounayar mouhamadalmounayar changed the title Regex multiple matches #690 Regex multiple matches Jul 10, 2024
@jmcook1186
Copy link
Contributor

looks good, thanks @mouhamadalmounayar - will get this reviewed shortly.
In order to merge, we need signed commits. You can satisfy the DCO requirement by adding a DCO remediation commit, as described here: https://github.com/Green-Software-Foundation/if/pull/901/checks?check_run_id=27267934777

@jmcook1186 jmcook1186 requested a review from manushak July 10, 2024 13:23
@manushak manushak modified the milestone: Inputs and Outputs Jul 10, 2024
@jmcook1186
Copy link
Contributor

Thanks for contributing @mouhamadalmounayar :o)

@jmcook1186
Copy link
Contributor

@mouhamadalmounayar looks like we haven't quite satisfied the DCO - maybe there was an error in your remediation commit. You can either squash, sign and force push or try again to add a remediation commit that covers the whole commit history.

@mouhamadalmounayar mouhamadalmounayar force-pushed the regex-multiple-matches branch 8 times, most recently from 52ef187 to 124594b Compare July 11, 2024 16:01
- Update output parameter documentation
- Added corresponding test case

Signed-off-by: mouhamadalmounayar <[email protected]>
@mouhamadalmounayar
Copy link
Contributor Author

mouhamadalmounayar commented Jul 11, 2024

@mouhamadalmounayar looks like we haven't quite satisfied the DCO - maybe there was an error in your remediation commit. You can either squash, sign and force push or try again to add a remediation commit that covers the whole commit history.

@jmcook1186 Yeah sorry about that, I had a problem with my gpg config. All good now.

@jmcook1186 jmcook1186 merged commit ad1c825 into Green-Software-Foundation:main Jul 12, 2024
1 check passed
This was referenced Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants