Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output manifests #874

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Add output manifests #874

merged 6 commits into from
Jul 4, 2024

Conversation

MariamKhalatova
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@MariamKhalatova MariamKhalatova self-assigned this Jul 2, 2024
@MariamKhalatova MariamKhalatova linked an issue Jul 2, 2024 that may be closed by this pull request
5 tasks
@manushak
Copy link
Contributor

manushak commented Jul 4, 2024

@MariamKhalatova, I noticed that some files in the manifest folder (all files in the bugs and features folders) have been removed but at the same time they have output files in the outputs folder. Was that done by mistake?

@jmcook1186
Copy link
Contributor

@manushak @MariamKhalatova yea this is ok - the examples folder is really just demo manifests for people to see how to implement our builtins and some common patterns - the outputs folder is more comprehensive and is intended to have larger coverage to uspport automated testing.

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@jmcook1186 jmcook1186 merged commit 3d74c63 into main Jul 4, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the add-outputs branch July 4, 2024 08:09
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
This was referenced Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create output files for automated testing
4 participants