Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If core plugin types #843

Merged
merged 14 commits into from
Jun 18, 2024
Merged

If core plugin types #843

merged 14 commits into from
Jun 18, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Use types and error util from if-core.

@narekhovhannisyan narekhovhannisyan self-assigned this Jun 14, 2024
jmcook1186
jmcook1186 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@jmcook1186 jmcook1186 merged commit 1d39e6b into main Jun 18, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the if-core-plugin-types branch June 18, 2024 08:04
@narekhovhannisyan
Copy link
Member Author

#593

This was referenced Jun 28, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narekhovhannisyan @manushak @jmcook1186