Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure errors in IF #793

Merged
merged 40 commits into from
Jun 13, 2024
Merged

Restructure errors in IF #793

merged 40 commits into from
Jun 13, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Tune error classes.
  • Move all messages to the strings config file.
  • Migrate unit tests.
  • Cover with new tests where necessary.

@narekhovhannisyan
feat(util): update error usage in plugin storage
9da09b6
@narekhovhannisyan
feat(util): drop build error message helper
e769eaa
@narekhovhannisyan
feat(util): make error classes granular
4251823
@narekhovhannisyan
feat(util): update errors usage in args
78972b1
@narekhovhannisyan
feat(util): update errors usage in aggregation helper
62f70d5
@narekhovhannisyan
revert(types): drop helpers
3269fc9
@narekhovhannisyan
feat(lib): update errors usage in load
1c826ea
@narekhovhannisyan
feat(lib): update errors usage in initalize
85a66dd
@narekhovhannisyan
feat(lib): update errors usage in exhaust
c39cbab
@narekhovhannisyan
feat(config): update strings to include all messages
7316703
@narekhovhannisyan
feat(builtins): update errors usage in sum
d9c047e
@narekhovhannisyan
feat(builtins): update errors usage in mock observations, do cosmetic…
d045266 
… fixes
@narekhovhannisyan
feat(builtins): update errors usage in subtract
c4ed3d8
@narekhovhannisyan
feat(builtins): update errors usage in shell
c21fb0f
@narekhovhannisyan
feat(builtins): update errors usage in sci-embodied
8c39901
@narekhovhannisyan
feat(builtins): update errors usage in sci
0d978f4
@narekhovhannisyan
feat(builtins): update errors usage in regex
296734a
@narekhovhannisyan
feat(builtins): update errors usage in multiply
c60a1ab
@narekhovhannisyan
feat(builtins): update errors usage in interpolation
58bdc8e
@narekhovhannisyan
feat(builtins): update errors usage in exponent
b11aa7e
@narekhovhannisyan
feat(builtins): update errors usage in divide
2e2b07f
@narekhovhannisyan
feat(builtins): update errors usage in csv lookup, optimize strategy
c16f46c
@narekhovhannisyan
feat(builtins): update errors usage coefficient
9b3ea3e
@narekhovhannisyan
feat(builtins): update errors usage time-sync
f088869
@narekhovhannisyan
feat(builtins): update errors usage group-by
b34df91
@narekhovhannisyan
feat(builtins): update errors usage export yaml
93adf71
@narekhovhannisyan
feat(builtins): update errors usage export csv
b6d9b20
@narekhovhannisyan
feat(builtins): update errors usage export csv raw
19f1eec
@narekhovhannisyan
test(util): migrate tests to use new errors
cfc89db
@narekhovhannisyan
test(lib): migrate tests to use new errors
fe46a8d
@narekhovhannisyan narekhovhannisyan self-assigned this Jun 10, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Jun 10, 2024 that may be closed by this pull request
Improve IF logging protocols #600
Closed
5 tasks
jmcook1186
jmcook1186 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit e1e9cd1 into main Jun 13, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the restructure-errors branch June 13, 2024 15:58
This was referenced Jun 28, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve IF logging protocols
3 participants
@narekhovhannisyan @manushak @jmcook1186