fix(src): check if packages empty so we don't return null

[adamaucamp]

Types of changes

• Enhancement (project structure, spelling, grammar, formatting)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

A description of the changes proposed in the Pull Request

Essentially just do a check if the returned packages from the environment with the npm --list command during setup actually returns anything, and return an empty object instead of null.

see this issue for more (link)[https://github.com//issues/739]

[jmcook1186]

hi - thanks a lot for the PR!
pinging @narekhovhannisyan to review as he is closest to this aspect of the project.

[narekhovhannisyan]

Hi @adamaucamp , thanks a lot for your contribution!
With the current solution, we will create an empty array by calling object entries on the empty object. And then we have an unnecessary call of the flattenDependencies function.

So what do you think about solving the problem with the following strategy?

const listDependencies = async () => {
  const {stdout} = await execPromise('npm list --json');
  const npmListResponse: NpmListResponse = JSON.parse(stdout);

  if (npmListResponse.dependencies) {
    const dependencies = Object.entries(npmListResponse.dependencies);

    return flattenDependencies(dependencies);
  }

  return [];
};

[adamaucamp]

Hi @narekhovhannisyan, that is a much better solution yes. I'll update the PR. thanks.