Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced if diff #738

Merged
merged 21 commits into from
May 28, 2024
Merged

Advanced if diff #738

merged 21 commits into from
May 28, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Introduces additional functionality to if diff

@narekhovhannisyan
fix(util): tune yaml validation schema
0ad4ca6
@narekhovhannisyan
fix(util): tune convert to xorable to handle objects
5248f24
@narekhovhannisyan
feat(lib): tune compare to do advanced execution check
98c8cd3
@narekhovhannisyan
fix(src): execution is present in catch
e6df2cd
@narekhovhannisyan
fix(util): in helpers return empty string if piped source is unvailable
ee57cab
@narekhovhannisyan
fix(util): move messages to strings, fix strategy
e5e7d91
@narekhovhannisyan
fix(types): add message to difference object
810d56a
@narekhovhannisyan
feat(lib): introduce classified error to load
f2908b7
@narekhovhannisyan
feat(config): move all error messages from if-diff to strings
0ffb6ed
@narekhovhannisyan
test(util): implement units for helpers
f979d67
@narekhovhannisyan
test(util): implement units for if diff cli args
79c1492
@narekhovhannisyan
test(lib): refine old tests, add units for if-diff loader
f8d6a07
@narekhovhannisyan
test(mocks): refine json
a7d294f
@narekhovhannisyan
test(mocks): add readline
2617ccc
@narekhovhannisyan
chore(src): fetch changes from if-diff
9ee3932
@narekhovhannisyan
test(util): gain unit coverage on args
d0f35ac
@narekhovhannisyan
test(util): add units for check if equal
32ed6dc
@narekhovhannisyan
test(lib): implement units for compare
dacd809
@narekhovhannisyan narekhovhannisyan self-assigned this May 24, 2024
@narekhovhannisyan narekhovhannisyan linked an issue May 28, 2024 that may be closed by this pull request
Apply more advanced matching criteria in if-diff #706
Closed
6 tasks
jmcook1186
jmcook1186 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I checked out locally and checked that all the acceptance criteria are satisfied. I also played around moving things around some demo manifests and did not find anything behaving unexpectedly. Also tried it with the piping method and that seems to work well too.
Nice one!

@jmcook1186 jmcook1186 added the qa label May 28, 2024
@MariamKhalatova MariamKhalatova merged commit 251e14b into main May 28, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the advanced-if-diff branch May 28, 2024 19:54
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply more advanced matching criteria in if-diff
3 participants
@narekhovhannisyan @jmcook1186 @MariamKhalatova