Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtins unit test #557

Merged
merged 17 commits into from
Mar 26, 2024
Merged

Builtins unit test #557

merged 17 commits into from
Mar 26, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Add unit tests for builtin plugins
  • Fix some minor bugs

jmcook1186
jmcook1186 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

narekhovhannisyan
narekhovhannisyan reviewed Mar 26, 2024
View reviewed changes
src/__mocks__/builtins/export-csv.ts
name: 'demo',
description: '',
tags: null,
aggregation: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it's undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assign undefined to aggregation here, then if needed I assign the valid data in the test

@narekhovhannisyan narekhovhannisyan merged commit 3703846 into main Mar 26, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the builtins-unit-test branch March 26, 2024 20:32
@manushak manushak mentioned this pull request Apr 1, 2024
Closed
This was referenced May 17, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manushak @narekhovhannisyan @jmcook1186 @MariamKhalatova