Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): add missing params to params.ts #521

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix(config): add missing params to params.ts #521

merged 3 commits into from
Mar 12, 2024

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Add missing params to params.ts

@jmcook1186 jmcook1186 self-assigned this Mar 12, 2024
@jmcook1186 jmcook1186 added bug Error, flaw or fault cli labels Mar 12, 2024
@jmcook1186 jmcook1186 added this to the IF Sprint 8: 4/3/24 - 15/3/24 milestone Mar 12, 2024
@narekhovhannisyan
Copy link
Member

@jmcook1186 shouldn't we add instance type too?

@jmcook1186
Copy link
Contributor Author

cloud/instance-type is already there

@narekhovhannisyan
Copy link
Member

@jmcook1186 ok in that case we should update manifests

narekhovhannisyan
narekhovhannisyan reviewed Mar 12, 2024
View reviewed changes
examples/manifests/nesting.yml Outdated
@@ -50,7 +50,7 @@ tree:
child-0:
defaults:
cpu/thermal-design-power: 100
grid/carbon-intensity: 800
cloud/grid/carbon-intensity: 800
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@jmcook1186 jmcook1186 merged commit 06731bd into main Mar 12, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the add-params branch March 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@manushak manushak manushak approved these changes

Assignees

@jmcook1186 jmcook1186

Labels
bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmcook1186 @narekhovhannisyan @manushak @MariamKhalatova