Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer manifest types #505

Merged
merged 15 commits into from
Mar 6, 2024
Merged

Infer manifest types #505

merged 15 commits into from
Mar 6, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Inferred all manifest related types from appropriate zod schema.

@narekhovhannisyan narekhovhannisyan added this to the IF Sprint 8: 4/3/24 - 15/3/24 milestone Mar 5, 2024
@narekhovhannisyan narekhovhannisyan removed this from the IF Sprint 8: 4/3/24 - 15/3/24 milestone Mar 5, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Mar 5, 2024 that may be closed by this pull request
Infer manifest types from zod schema #494
Closed
jmcook1186
jmcook1186 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm - checked out locally and confirmed unit tests passing. Tested a selection of example manifests and confirmed correct execution.

@narekhovhannisyan narekhovhannisyan merged commit 71fd3f4 into main Mar 6, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the infer-manifest-types branch March 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infer manifest types from zod schema
3 participants
@narekhovhannisyan @manushak @jmcook1186