Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating if-demo functional-unit-time to match expected value #471

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

dcrreynolds
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Small update to one of the examples so the functional-unit-time value is accepted by the regex validation of the string. Otherwise an error InputValidationError: "functional-unit-time" parameter is invalid. Error code: invalid_string. is thrown.

@jmcook1186
Copy link
Contributor

Hi - thanks for the PR - you can actually also delete the functional-unit-duration field altogether - it's no longer used.

Also, merging is blocked on DCO - if you agree with the DCO terms you can add a DCO remediation commit to unblock (see the instructions in the DCO details above)

DCO Remediation Commit for dareynol <[email protected]>

I, dareynol <[email protected]>, hereby add my Signed-off-by to this commit: 042eba7

Signed-off-by: dareynol <[email protected]>
@dcrreynolds
Copy link
Contributor Author

Thank you for the feedback! I removed functional-unit-duration, added the missing version stamp, and made DCO happy.

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@jmcook1186 jmcook1186 merged commit 012bcf8 into Green-Software-Foundation:dev Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants