Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exhaust: added exhaust function, with stub for exhaust-csv-export and… #441

Merged

Conversation

pazbardanl
Copy link
Contributor

@pazbardanl pazbardanl commented Feb 18, 2024

… a sample impl

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • added exhaust function
  • added csv-exporter exhaust plugin

@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch from 737e873 to a9af7dd Compare February 18, 2024 06:59
…so need to imnplement configuration of: file name, custom headers (optional)

Signed-off-by: Paz Barda <[email protected]>
@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch from a9af7dd to c6b8484 Compare February 18, 2024 07:01
@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch from e1583a5 to 461f4f7 Compare February 18, 2024 19:52
import {ExhaustExportCsv} from '../models/exhaust-export-csv';

const createExhaustPlugin = (pluginTypeName: string) => {
switch (pluginTypeName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should discuss if plugins are another repository or builtins

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we got approval to import exhaust plugins as we are doing with ordinary plugins

Copy link
Contributor Author

@pazbardanl pazbardanl Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in retrospect i think this makes sense.

looking at the way ordinary plugins are being created from the manifest, i think applying a similar flow for creation of the exhaust plugins means significant changes relative to the PR state as it is right now.

i still think we should do it :) but maybe not in the scope of this task.
i propose maybe pushing the csv-export exhaust functionality as it is in this PR, and create a new issue (with the relevant priority) for refactoring it into external plugins. this actually means 2 PRs: one for IF exhaust infra and the other for a CSV exporter exhaust plugin.

The main reason im proposing it is that Joseph said in last weekly call he is very eager to be able to show the csv-export functionality.

WDYT?

@pazbardanl pazbardanl marked this pull request as draft February 19, 2024 10:05
@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch 2 times, most recently from e0d36c5 to 7db9860 Compare February 20, 2024 19:46
@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch 2 times, most recently from e05231f to 171a812 Compare February 22, 2024 19:28
@pazbardanl pazbardanl force-pushed the functional-architecture-exhaust-csv branch from 171a812 to fcbf885 Compare February 22, 2024 19:57
@pazbardanl pazbardanl marked this pull request as ready for review February 22, 2024 19:57
@narekhovhannisyan narekhovhannisyan merged commit 8281f4a into functional-architecture Mar 1, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the functional-architecture-exhaust-csv branch March 1, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants