Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify the regroup code #1049

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Prettify the regroup code #1049

merged 1 commit into from
Oct 15, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Copy link
Contributor

@manushak manushak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narekhovhannisyan these changes do not solve the problem. When executing the regroup manifest, it still regroups again

@narekhovhannisyan
Copy link
Member Author

@manushak we decided to leave that for now, since it requires a lot of changes. This one is just refactored version of initial code.

@Eakinter99
Copy link

@narekhovhannisyan these changes do not solve the problem. When executing the regroup manifest, it still regroups again

@narekhovhannisyan
Copy link
Member Author

Hi @Eakinter99, thanks for the feedback. You can check my message in the thread above.

@narekhovhannisyan narekhovhannisyan merged commit 3f5f16f into main Oct 15, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the regroup-check branch October 15, 2024 05:53
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants