Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Granular aggregation #1008

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Granular aggregation #1008

merged 19 commits into from
Sep 10, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@narekhovhannisyan
feat(util): enable granular aggregation in helper
098a23e
@narekhovhannisyan
feat(types): use aggregation options as method
5f6b055
@narekhovhannisyan
feat(types): enable time and component aggregations
ea5270f
@narekhovhannisyan
fix(lib): update docs, improve readablity in initialize
e4e01e2
@narekhovhannisyan
feat(lib): use granular aggregation in explain
bca7629
@narekhovhannisyan
feat(lib): introduce granular aggregation to aggregate
d456789
@narekhovhannisyan
feat(config): rename additional params to time metrics
668dfba
@narekhovhannisyan
feat(builtins): use granular aggregation in time sync
dc840e6
@narekhovhannisyan
feat(builtins): use granular aggregation methods in sci embodied
2930d43
@narekhovhannisyan
feat(builtins): use granular aggregation methods in sci
3a9c12f
@narekhovhannisyan
feat(src): simplify if-run index
1fa4dec
@narekhovhannisyan
feat(util): introduce granular aggregation to validation
6938764
@narekhovhannisyan
feat(types): enable time and component aggregations in manifest
2d53237
@narekhovhannisyan
test(util): tune aggregation helper units
c9aeaf9
@narekhovhannisyan
test(lib): tune explain units
a650544
@narekhovhannisyan
test(lib): tune aggregate units
0113ed5
@narekhovhannisyan
test(builtins): tune time-sync units
79ead4c
@narekhovhannisyan narekhovhannisyan self-assigned this Sep 9, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Sep 9, 2024 that may be closed by this pull request
Allow different aggregation methods for time and component aggregation #991
Closed
5 tasks
@narekhovhannisyan
Copy link
Member Author

@jmcook1186 @manushak build will be resolved after updating if-core version.

@narekhovhannisyan
Copy link
Member Author

Updated

jmcook1186
jmcook1186 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narekhovhannisyan narekhovhannisyan merged commit a6b518f into main Sep 10, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the granular-aggregation branch September 10, 2024 12:39
@jmcook1186 jmcook1186 mentioned this pull request Sep 12, 2024
Open
@narekhovhannisyan narekhovhannisyan mentioned this pull request Sep 23, 2024
Closed
6 tasks
This was referenced Oct 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow different aggregation methods for time and component aggregation
3 participants
@narekhovhannisyan @manushak @jmcook1186