Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit import paths for all manifests in if #740

Closed
3 tasks
Tracked by #656
zanete opened this issue May 28, 2024 · 3 comments · Fixed by #747
Closed
3 tasks
Tracked by #656

Audit import paths for all manifests in if #740

zanete opened this issue May 28, 2024 · 3 comments · Fixed by #747
Assignees
Labels
draft The issue is still being written, no need to respond or action on anything.
Milestone

Comments

@zanete
Copy link

zanete commented May 28, 2024

What

Check through all existing manifests and ensure that the import paths for plugins are correct. This especially applies to plugins that have recently been moved from if-plugins to builtins as there may be some trailing path: @gtnsft/if-plugins that need to be updated.

Why

To ensure all our example manifests execute correctly.

SoW

  • check through all existing manifests and identify cases where the import path is incorrect
  • raise a single PR fixing all instances of incorrect import path

Acceptance criteria

  • all import paths are correct
    • GIVEN the audit is complete
      WHEN I execute all the manifests that come bundled with IF
      THEN every manifest executes correctly OR fails in the expected way.
@zanete zanete added this to IF May 28, 2024
@zanete zanete converted this from a draft issue May 28, 2024
@zanete
Copy link
Author

zanete commented May 28, 2024

@jmcook1186 confirm if this is needed and assign to @MariamKhalatova if it is

@zanete zanete assigned jmcook1186 and unassigned MariamKhalatova May 28, 2024
@zanete zanete added draft The issue is still being written, no need to respond or action on anything. epic: QA labels May 28, 2024
@jmcook1186 jmcook1186 changed the title Confirm we have success and failure manifests for all new built-ins Audit import paths for all manifests if if May 28, 2024
@jmcook1186 jmcook1186 changed the title Audit import paths for all manifests if if Audit import paths for all manifests in if May 28, 2024
@zanete zanete moved this from Ready to In Progress in IF May 29, 2024
@MariamKhalatova MariamKhalatova moved this from In Progress to Testing in IF May 29, 2024
@zanete
Copy link
Author

zanete commented May 30, 2024

a PR expected in a few hours 🙏

@MariamKhalatova MariamKhalatova linked a pull request May 30, 2024 that will close this issue
9 tasks
@MariamKhalatova
Copy link
Contributor

a PR expected in a few hours 🙏

@zanete PR is already provided. Waiting for it to be reviewed

@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 31, 2024
@zanete zanete added this to the Improve Trust milestone Jun 5, 2024
@zanete zanete mentioned this issue Jun 5, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft The issue is still being written, no need to respond or action on anything.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants