Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate subtract from if-plugins to builtins #722

Closed
6 tasks
Tracked by #656
jmcook1186 opened this issue May 20, 2024 · 0 comments · Fixed by #723
Closed
6 tasks
Tracked by #656

Migrate subtract from if-plugins to builtins #722

jmcook1186 opened this issue May 20, 2024 · 0 comments · Fixed by #723
Assignees
Milestone

Comments

@jmcook1186
Copy link
Contributor

jmcook1186 commented May 20, 2024

Sub of: #656

What
Move the subtract plugin from if-plugins to if/builtins

Why
This is part of our migration of our core plugins into a standard library in if/builtins.

Context
This is a core feature we want to support, so it is migrating into if.

Prerequisites/resources
no

SoW (scope of work)

  • move plugin code into builtins/subtract
  • fix any integration issues caused by the migration
  • migrate and fix unit tests
  • update README documentation updated

Acceptance criteria

  • plugin code is migrated to if-builtins
    Given (Setup): The migration has been completed.
    When (Action): A user or developer navigates to if
    Then (Assertion): they will find a folder if/builtins/subtract containing the plugin source code and a README.

  • plugin code and unit tests pass and maintain 100% coverage
    Given (Setup): The migration has been completed and a user has downloaded if.
    When (Action): they run npx jest --coverage
    Then (Assertion): they will receive a report showing 100% coverage and 100% passing

@jmcook1186 jmcook1186 self-assigned this May 20, 2024
@jmcook1186 jmcook1186 added this to IF May 20, 2024
@jmcook1186 jmcook1186 moved this to In Progress in IF May 20, 2024
@jmcook1186 jmcook1186 linked a pull request May 20, 2024 that will close this issue
9 tasks
@zanete zanete moved this from In Progress to Pending Review in IF May 21, 2024
@zanete zanete moved this from Pending Review to In Progress in IF May 21, 2024
@zanete zanete moved this from In Progress to Pending Review in IF May 21, 2024
@zanete zanete moved this from Pending Review to Testing in IF May 21, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 23, 2024
@zanete zanete added this to the Improve Trust milestone Jun 5, 2024
@zanete zanete mentioned this issue Jun 5, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants