Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugins and manifest for measuring a webpage #63

Conversation

alexzurbonsen
Copy link
Contributor

@alexzurbonsen alexzurbonsen commented Mar 20, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

WIP

A description of the changes proposed in the Pull Request

Plugins for measuring a webpage. Plus additional plugin for looking up green hosting. Plus plugin for measuring time (also opened a PR for that separately).

One based on puppeteer.
The other one on lighthouse.

There is also an example manifest file for the puppeteer plugin.

Tests for the measurement plugins are still missing.

More infos to follow.

Committed without pre-commit hook because tests are still missing.

Signed-off-by: alexzurbonsen <[email protected]>
This plugin takes in a url, extracts the domain and queries the
green web foundation database for green hosting. Returns a boolean
that indicates whether the domain is hosted green or not.

Signed-off-by: alexzurbonsen <[email protected]>
refer to readme for further info

Signed-off-by: alexzurbonsen <[email protected]>
@jmcook1186
Copy link
Contributor

Hi @alexzurbonsen thanks for this, but we are unlikely to merge this into if-unofficial-plugins. The reason is that ultimately want to remove this repo entirely and encourage people to build new plugins in their own repositories separate from the IF. This is because the vision is to have thousands of plugins and we don't want the core team's ability to maintain them to be a bottleneck on ecosystem growth. So, in summary I encourage you to develop this in your own repo. This is exactly the kind of plugin we want people to host externally to IF.

@alexzurbonsen
Copy link
Contributor Author

@jmcook1186 sure, makes sense to me. I also wasn't sure what you idea is on how this should be handled. There is also a hackathon issue for this and I wanted to share what I worked on so far with the group. Thus, it is still a draft and will remain one.

@alexzurbonsen
Copy link
Contributor Author

alexzurbonsen commented Mar 21, 2024

What's the vision on how people should find existing plugins, by the way? Is there some sort of registry?

@jmcook1186
Copy link
Contributor

Yes, there will be - we were just sketching out some plans for this earlier in the week. Without committing to a specific path right now, we anticipate maintaining some kind of simple centralized list or explorer for other people's plugins. (tbh right now there aren't very many, so this is a problem for after the hackathon when the available set is much larger)

@alexzurbonsen
Copy link
Contributor Author

Thanks for the info. That is good to know. Sorry, if I missed this piece of information in the docs somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants