Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors layer #6

Merged
merged 13 commits into from
Nov 23, 2023
Merged

Errors layer #6

merged 13 commits into from
Nov 23, 2023

Conversation

narekhovhannisyan
Copy link
Member

@narekhovhannisyan narekhovhannisyan commented Nov 22, 2023 •
edited by jmcook1186
Loading

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Introduced new error layer.
  • Updated appropriate tests.

Partially closes Green-Software-Foundation/if#180

@narekhovhannisyan narekhovhannisyan marked this pull request as draft November 22, 2023 17:43
@narekhovhannisyan narekhovhannisyan changed the title Errors layout Errors layer Nov 23, 2023
@narekhovhannisyan narekhovhannisyan marked this pull request as ready for review November 23, 2023 11:41
@jmcook1186 jmcook1186 added the tests related to unit or integration tests label Nov 23, 2023
jmcook1186
jmcook1186 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks!

@jmcook1186 jmcook1186 merged commit eba477d into main Nov 23, 2023
2 checks passed
@jmcook1186 jmcook1186 deleted the errors-layout branch November 23, 2023 12:47
@jawache jawache mentioned this pull request Apr 22, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@gnanakeethan gnanakeethan Awaiting requested review from gnanakeethan

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
tests related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Models return useful exceptions
2 participants
@narekhovhannisyan @jmcook1186