Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes and release notes post for 1.6 #568

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Docs fixes and release notes post for 1.6 #568

merged 9 commits into from
Sep 24, 2024

Conversation

danuw
Copy link
Collaborator

@danuw danuw commented Sep 24, 2024

Pull Request

Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)

Summary

Fix for the release where docs workflow fails

Changes

  • List of comprehensive changes

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #<issue_number>

@danuw
Copy link
Collaborator Author

danuw commented Sep 24, 2024

Workflow fails again.

FYI
My local uses

node -v
v20.9.0
npm -v
10.8.2

and docusaurus is 3.4.0 (as it is telling me to update to 3.5.2)

I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: d3b054b
I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: f412591

Signed-off-by: Dan Benitah <[email protected]>
Signed-off-by: Dan Benitah <[email protected]>
@danuw
Copy link
Collaborator Author

danuw commented Sep 24, 2024

we probably need to freeze the dependencies into a yarn lock which we dont yet have to see if that helps secure a steady set of dependencies for docusaurus to work seemlessly.

@tiwatsuka
Copy link
Contributor

tiwatsuka commented Sep 24, 2024

@danuw
I succeeded to build the docs with changing versions of the libraries.
tiwatsuka@8173906
https://github.com/tiwatsuka/carbon-aware-sdk/actions/runs/11010398839/job/30572233520

Could you generate yarn.lock by running yarn install on your local machine without --frozen-lockfile option and commit it to the repository? I suppose package-lock.json is no longer needed as long as we use yarn to build.

@tiwatsuka
Copy link
Contributor

tiwatsuka commented Sep 24, 2024

@danuw My apologies for the lack of clarity. You also need to apply the change I made below before generate yarn.lock.
tiwatsuka@8173906

Signed-off-by: Dan Benitah <[email protected]>
@danuw
Copy link
Collaborator Author

danuw commented Sep 24, 2024

Thank you very much I was creating a new test folder to get just that - thank you

I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: eae5bd1

Signed-off-by: Dan Benitah <[email protected]>
@danuw
Copy link
Collaborator Author

danuw commented Sep 24, 2024

@tiwatsuka / @YaSuenag could you review and approve please? and I hope do the same for the main branch too please?

@danuw danuw added the v1.6 label Sep 24, 2024
@danuw danuw added this to the Release 1.6 milestone Sep 24, 2024
@danuw danuw merged commit c50f5f5 into dev Sep 24, 2024
10 checks passed
@danuw
Copy link
Collaborator Author

danuw commented Sep 24, 2024

Thank you @YaSuenag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants