-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fixes and release notes post for 1.6 #568
Conversation
Signed-off-by: Dan Benitah <[email protected]>
Workflow fails again. FYI
and docusaurus is |
I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: d3b054b I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: f412591 Signed-off-by: Dan Benitah <[email protected]>
Signed-off-by: Dan Benitah <[email protected]>
Signed-off-by: Dan Benitah <[email protected]>
we probably need to freeze the dependencies into a yarn lock which we dont yet have to see if that helps secure a steady set of dependencies for docusaurus to work seemlessly. |
@danuw Could you generate |
@danuw My apologies for the lack of clarity. You also need to apply the change I made below before generate |
Signed-off-by: Dan Benitah <[email protected]>
Thank you very much I was creating a new test folder to get just that - thank you |
I, Dan Benitah <[email protected]>, hereby add my Signed-off-by to this commit: eae5bd1 Signed-off-by: Dan Benitah <[email protected]>
@tiwatsuka / @YaSuenag could you review and approve please? and I hope do the same for the main branch too please? |
Thank you @YaSuenag |
Pull Request
Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)
Summary
Fix for the release where docs workflow fails
Changes
Checklist
Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.
This PR Closes #<issue_number>