Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: "it's" is used incorrectly several times #553

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

trent-s
Copy link
Contributor

@trent-s trent-s commented Aug 13, 2024

Pull Request

Issue Number: 552

Summary

There are three places in the documentation where "it's" is used incorrectly, and should be replaced with "its".

Changes

File: README.md
Original: The Carbon Aware SDK at it's core sits firmly in the Tooling pillar,
Proposed: The Carbon Aware SDK at its core sits firmly in the Tooling pillar,

File: casdk-docs/docs/architecture/data-sources.md
Original: within it's implementation.
Proposed: within its implementation.

File: casdk-docs/docs/architecture/data-sources.md
Original: under it's purview
Proposed: under its purview

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No API changes.

Is this a breaking change?

No. This is just a minor documentation change.

Anything else?

Thank you for your ongoing work and consideration of this PR.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #552

@trent-s trent-s requested a review from vaughanknight as a code owner August 13, 2024 07:32
Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danuw danuw added the v1.6 label Aug 14, 2024
@danuw danuw self-assigned this Aug 14, 2024
@danuw danuw merged commit 89a5ba3 into Green-Software-Foundation:dev Aug 14, 2024
8 checks passed
@danuw danuw added this to the Release 1.6 milestone Sep 10, 2024
@danuw danuw modified the milestones: Release 1.6, Release 1.7 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation: "it's" is used incorrectly several times
2 participants