Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env directive to values.yaml and troubleshooting guide to avoid inotify limitation on Linux #544

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Jul 20, 2024

Pull Request

#528

Summary

Add troubleshooting document to avoid System.IO.IOException caused by number of inotify instances on Linux, and add env directive to values.yaml in Helm chart. See #528 for details.

Changes

  • CASDK document
  • values.yaml in Helm chart

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

This PR Closes #528

@YaSuenag YaSuenag requested a review from vaughanknight as a code owner July 20, 2024 03:03
Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (it is to turn off dynamic configuration in app settings via env vars)

@danuw danuw merged commit 4a8aa9e into Green-Software-Foundation:dev Aug 27, 2024
8 checks passed
@danuw danuw added the v1.6 label Aug 27, 2024
@YaSuenag YaSuenag deleted the pr/inotify branch August 27, 2024 07:42
@YaSuenag
Copy link
Member Author

@danuw Thank you for reviewing & merging!
This PR is for Helm chart, so could you kick GHA workflow for publishing? https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/.github/workflows/5-publish-helm-chart.yaml

@danuw danuw modified the milestones: Release 1.6, Release 1.7 Nov 5, 2024
@danuw danuw removed this from the Release 1.7 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Avoid inotify limit in WebAPI container on Kubernetes
2 participants