-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA workflow for generating WebAPI client library for Java #471
Add GHA workflow for generating WebAPI client library for Java #471
Conversation
@danuw I want to hear your opinion especially following topics:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @YaSuenag 's comments we are waiting on a dependency from .net 8 migration changes.
Blocked merge for now
Signed-off-by: Yasumasa Suenaga <[email protected]>
dd32075
to
d0d5e72
Compare
I updated this PR. This refer to .NET 8 migrated WebAPI container, then it works fine on my forked repo. Please review! |
Signed-off-by: Yasumasa Suenaga <[email protected]>
I updated this PR to upload client API doc for Java (aka Javadoc) to |
Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
81adc17
to
d650520
Compare
This commit fixes not to refer variables deleted by b502723 . Signed-off-by: Yasumasa Suenaga <[email protected]>
@danuw @vaughanknight So can you review this? Note that this workflow would create a commit for API document (Javadoc) to default branch ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's generate those client libraries and monitor if any issues
c.SwaggerDoc("v1", new OpenApiInfo | ||
{ | ||
Version = "CarbonAware.WebAPI", | ||
Title = "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be added to project assembly variables in the future? so version is not maintained as hardcoded value in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's apply the related changes (if any, in the NPM PR that should follow)
Pull Request
This is successor of #359
Summary
Add GHA workflow to generate WebAPI client library for Java. This workflow would be triggered when API version in
swagger.yaml
is updated in each release. Client library would be published into GitHub Packages. See my package repo as an example: https://github.com/YaSuenag/carbon-aware-sdk/packages/2078122This PR introduced 3 workflow files:
swagger.yaml
inlatest
container in GitHub Packages4-release.yaml
and workflow dispatch4-release.yaml
if API version is not updated in the releaseAPI document (Javadoc) would be added
client-apidocs
ingh-pages
branch directly. See my repo as an example: https://github.com/YaSuenag/carbon-aware-sdk/tree/gh-pages/client-apidocsIf you want to add another WebAPI clients (JS, Python, .NET, and so on), you need to add new workflow for generating, and add its entry point to
generate-webapi-clients.yaml
.Changes
This PR contains 3 siginificant commits. I left them due to ease of review, but you can squash them when you merge.
Checklist
Are there API Changes?
Clarify API version in
swagger.yaml
. Current version is1.0
(maybe it is default by .NET), new version is1.0.0
.Is this a breaking change?
API version in
swagger.yaml
(1.0
-1.0.0
)Anything else?
config.json
for OpenAPI generator: