Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon hack 24 banner image fix #463

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Carbon hack 24 banner image fix #463

merged 2 commits into from
Feb 13, 2024

Conversation

danuw
Copy link
Collaborator

@danuw danuw commented Feb 12, 2024

Pull Request

Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)

Summary

CarbonHack 24 banner added to readme

Changes

  • CarbonHack 24 banner missed image now added

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Documentation Updates Made?

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #460

linking to the new banner

Signed-off-by: Dan Benitah <[email protected]>
Signed-off-by: Dan Benitah <[email protected]>
@danuw danuw requested a review from Sophietn February 12, 2024 17:04
@danuw danuw requested a review from vaughanknight as a code owner February 12, 2024 17:04
Copy link
Contributor

@Sophietn Sophietn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - new file

@danuw danuw merged commit e0507cf into dev Feb 13, 2024
8 checks passed
@danuw danuw deleted the danuw-hack-banner-image-fix branch February 13, 2024 01:49
@danuw danuw mentioned this pull request Feb 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Contribution]: CarbonHack 24 banner added to readme to match IF and other GSF repos
2 participants