Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update carbon-aware-cli.md #452

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

JasonLuuk
Copy link
Contributor

@JasonLuuk JasonLuuk commented Jan 27, 2024

Fixes bugs with Linux scripts

Pull Request

Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)

Summary

One sentence summary of PR

Changes

  • List of comprehensive changes

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #<issue_number>

Fixes bugs with Linux scripts

Signed-off-by: JasonLuuk <[email protected]>
@danuw
Copy link
Collaborator

danuw commented Jan 28, 2024

LGTM

Copy link
Collaborator

@Willmish Willmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the first \ occurance is crucial as it shows the difference between running the executable on Windows and UNIX based systems. I think its acceptable to change the rest as they don't have .exe extension and its straightforward enough to choose right format based on the beginning of the doc.

Thanks for the contribution @JasonLuuk , glad to see more PRs coming out of UCL 🚀

@Willmish Willmish merged commit b70c8ed into Green-Software-Foundation:dev Feb 6, 2024
8 checks passed
@danuw danuw mentioned this pull request Feb 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants