-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support location source setting in Helm chart #449
Support location source setting in Helm chart #449
Conversation
Signed-off-by: Yasumasa Suenaga <[email protected]>
@vaughanknight @danuw @YaSuenag Configuration:
After executing
|
Signed-off-by: Yasumasa Suenaga <[email protected]>
I set new version (1.1.0) for Helm chart in this PR. As I wrote in #381 , Helm chart release can happen asynchronously with CASDK release. So I hope new Helm chart will be published after merging this PR - it means CASDK mainteiner kicks https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/.github/workflows/5-publish-helm-chart.yaml manually. |
Thanks both and @tiwatsuka for the review and test confirmation |
Thank you for merging! Could you kick 5-publish-helm-chart.yaml to publish this chart? |
Helm chart v1.1.0 has been published: https://github.com/Green-Software-Foundation/carbon-aware-sdk/pkgs/container/charts%2Fcarbon-aware-sdk/178053794?tag=1.1.0 Thanks a lot @danuw ! |
Pull Request
Summary
Add location source configuration to Helm chart
Changes
locationSources
key to configure location source JSON...
inlocation-source
directory (Kubernetes sets real configuration file with..
)Checklist
Are there API Changes?
No
Is this a breaking change?
No
Anything else?
I want to update Helm chart version and to publish new chart container if this PR is accepted.