Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR Proposal: Throws exception when future datetime is passed to current/historical APIs #406

Closed
wants to merge 1 commit into from

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Oct 19, 2023

Pull Request

#396

Summary

Propose to throw exception / return HTTP error status when future datetime is passed to current/historical APIs.

Changes

Add ADR about this topic. See ADR-0016 document in this PR for details.

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

Signed-off-by: Yasumasa Suenaga <[email protected]>
@YaSuenag YaSuenag changed the title ADR Propose: Throws exception when future datetime is passed to current/historical APIs ADR Proposal: Throws exception when future datetime is passed to current/historical APIs Oct 19, 2023
@danuw
Copy link
Collaborator

danuw commented Nov 9, 2023

Seems like a good idea. To discuss on next meeting I guess.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

This a stale pull request. Please review, update or/and close as necessary.

@danuw
Copy link
Collaborator

danuw commented May 1, 2024

Shall we reopen this ?

@YaSuenag @vaughanknight

@YaSuenag
Copy link
Member Author

YaSuenag commented May 2, 2024

Sure, I think this proposal should go further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants