Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Data Source Registration per ADR-0006 #366

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bderusha
Copy link
Contributor

@bderusha bderusha commented Jun 26, 2023

Pull Request

Issue Number: #348

Summary

Loads data sources declared in the .csproj file and configured using the standard configuration dynamically rather than through the hardcoded registration project.

There are many files with tiny, ancillary changes necessary to plumb everything together this way. However the main changes are to the data source files:

And the Configuration class
And the ServiceCollectionExtension

Changes

  • Dynamic loading support
  • All data sources updated to match the interface
  • Updated documentation

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

Yes, projects using the SDK Library now must declare data source packages explicitly.

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #348

@bderusha bderusha requested review from danuw and Willmish June 26, 2023 14:14
@bderusha bderusha changed the title Feat/dynamic data sources Implement Data Source Registration per ADR-0006 Jun 26, 2023
@bderusha bderusha force-pushed the feat/dynamic-data-sources branch 4 times, most recently from 68e6f35 to fbbd9af Compare June 29, 2023 13:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #366 (ac5aae6) into dev (ad44005) will increase coverage by 5.35%.
Report is 7 commits behind head on dev.
The diff coverage is 65.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #366      +/-   ##
==========================================
+ Coverage   74.21%   79.56%   +5.34%     
==========================================
  Files          77       75       -2     
  Lines        2637     2701      +64     
  Branches      266      268       +2     
==========================================
+ Hits         1957     2149     +192     
+ Misses        598      457     -141     
- Partials       82       95      +13     
Files Changed Coverage Δ
src/CarbonAware.WebApi/src/Program.cs 80.26% <ø> (ø)
src/CarbonAware/src/Interfaces/IDataSource.cs 0.00% <0.00%> (ø)
...psFree/mock/ElectricityMapsFreeDataSourceMocker.cs 95.12% <33.33%> (ø)
...s.ElectricityMaps/src/ElectricityMapsDataSource.cs 61.31% <50.00%> (-2.77%) ⬇️
...icityMapsFree/src/ElectricityMapsFreeDataSource.cs 63.63% <50.00%> (+63.63%) ⬆️
...are.DataSources.WattTime/src/WattTimeDataSource.cs 88.53% <74.28%> (-4.09%) ⬇️
...ware/src/Configuration/DataSourcesConfiguration.cs 89.65% <75.00%> (-10.35%) ⬇️
...ware/src/Extensions/ServiceCollectionExtensions.cs 76.19% <76.19%> (ø)
...CarbonAware.DataSources.Json/src/JsonDataSource.cs 80.76% <84.61%> (+0.76%) ⬆️
...onfiguration/DataSourcesConfigurationExtensions.cs 83.33% <100.00%> (ø)
... and 1 more

... and 6 files with indirect coverage changes

@bderusha bderusha force-pushed the feat/dynamic-data-sources branch 5 times, most recently from 7065dce to c3d13a3 Compare June 30, 2023 16:54
@bderusha bderusha force-pushed the feat/dynamic-data-sources branch 16 times, most recently from 726c716 to c47f1bc Compare September 5, 2023 20:29
@bderusha bderusha force-pushed the feat/dynamic-data-sources branch from c47f1bc to 408fcb1 Compare September 11, 2023 15:49
@bderusha
Copy link
Contributor Author

@danuw @Willmish @vaughanknight Anything I can do to help land this PR?

@danuw
Copy link
Collaborator

danuw commented May 14, 2024

@bderusha , I can see there are some outstanding conflicts here - are you able to help update and see how we can progress please?

@bderusha
Copy link
Contributor Author

@danuw Is this PR something the community is ready to review and merge?

If yes, and we are going to prioritize this PR, I can prioritize making the required updates (both to current conflicts and any feedback).

@NAMRATA-WOKE
Copy link

@danuw is there an update here that you'd like to share with the rest of the community?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review PR Ready for review with the GSF team for merge v1.7
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Feature Contribution]: Implement Data Source Registration per ADR-0006
6 participants