-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Data Source Registration per ADR-0006 #366
base: dev
Are you sure you want to change the base?
Implement Data Source Registration per ADR-0006 #366
Conversation
68e6f35
to
fbbd9af
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #366 +/- ##
==========================================
+ Coverage 74.21% 79.56% +5.34%
==========================================
Files 77 75 -2
Lines 2637 2701 +64
Branches 266 268 +2
==========================================
+ Hits 1957 2149 +192
+ Misses 598 457 -141
- Partials 82 95 +13
|
7065dce
to
c3d13a3
Compare
726c716
to
c47f1bc
Compare
c47f1bc
to
408fcb1
Compare
@danuw @Willmish @vaughanknight Anything I can do to help land this PR? |
@bderusha , I can see there are some outstanding conflicts here - are you able to help update and see how we can progress please? |
@danuw Is this PR something the community is ready to review and merge? If yes, and we are going to prioritize this PR, I can prioritize making the required updates (both to current conflicts and any feedback). |
@danuw is there an update here that you'd like to share with the rest of the community? |
Pull Request
Issue Number: #348
Summary
Loads data sources declared in the
.csproj
file and configured using the standard configuration dynamically rather than through the hardcoded registration project.There are many files with tiny, ancillary changes necessary to plumb everything together this way. However the main changes are to the data source files:
And the Configuration class
And the ServiceCollectionExtension
Changes
Checklist
Are there API Changes?
No
Is this a breaking change?
Yes, projects using the SDK Library now must declare data source packages explicitly.
Anything else?
Other comments, collaborators, etc.
This PR Closes #348