Emissions-forecasts with ElectricityMaps will return server error 500 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue : I have tested a ElectricityMaps forecast scenario CLI: "emissions-forecasts -l westeurope -v" will return server error 500. Analysis: public async Task<EmissionsForecast> GetCurrentCarbonIntensityForecastAsync(Location location) is causing the EM server to return 500. Reason is that the "." in geolocation.Latitude will be passed as "," Fix: The following changes are fixing this bug. Signed-off-by: Christian Binder <[email protected]>
FabioTurati-NTT
approved these changes
Jun 19, 2023
bderusha
approved these changes
Jun 29, 2023
bderusha
added
the
Ready for Review
|
@vaughanknight @Willmish Can you kick off the tests? |
|
#367 meeting update: @vaughanknight to connect with PR owner and discuss further |
This was referenced Jul 11, 2023
|
Changes have been approved by @bderusha and @FabioTurati-NTT - moving this on. |
14 tasks
danuw
removed
the
Ready for Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number: #364
Summary
ElectricityMaps forecast scenario will return server error 500.
Repro using CLI: "emissions-forecasts -l westeurope -v"
public async Task GetCurrentCarbonIntensityForecastAsync(Location location) is causing the EM server to return 500. Reason is that the "." in geolocation.Latitude will be passed as ","
Changes
public async Task<EmissionsForecast> GetCurrentCarbonIntensityForecastAsync(Location location)if (geolocation.Latitude != null && geolocation.Longitude != null)GetForecastedCarbonIntensityAsync(geolocation.LatitudeAsCultureInvariantString(), geolocation.LongitudeAsCultureInvariantString());Checklist
Is this a breaking change?
If yes, what workflow does this break?
This PR Closes #364