-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated documentation to refer to the new arch diagram #353
updated documentation to refer to the new arch diagram #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
@Willmish @vaughanknight This is ready for GSF review |
Hi @pritipath and thanks for adding the correct diagram! Regarding the DCO, if you could please fix this before it gets merged in, you have added a remediation for ec4270a but not for d9fdbe3 - please see issue #309 for possible suggestions on how to fix this - for example Fabio's comment explains a nice method with git rebasing: #309 (comment)) OR SEE BELOW for suggested course of action. Preferably you would also remove the 2 empty commits with incorrect DCO remediation. To do this:
Hopefully this is will help you out in fixing the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diagram looks good, but please see DCO comment.
#363 - @pritipath resurfacing |
I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: ec4270a I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: d9fdbe3 Signed-off-by: Priti <[email protected]>
975b339
to
8450995
Compare
@Willmish Fixed. Sorry for the delay, missed this somehow. |
This a stale pull request. Please review, update or/and close as necessary. |
Pull Request
Issue Number: #352
Summary
Updated documentation to refer to the new architecture diagram
Changes
Checklist
Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.
This PR Closes #352