Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated documentation to refer to the new arch diagram #353

Closed

Conversation

pritipath
Copy link
Contributor

Pull Request

Issue Number: #352

Summary

Updated documentation to refer to the new architecture diagram

Changes

  • List of comprehensive changes

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #352

@pritipath pritipath requested a review from vaughanknight as a code owner May 15, 2023 16:10
Copy link
Contributor

@juzuluag juzuluag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

juzuluag added 5 commits May 15, 2023 12:18
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
Signed-off-by: Juan Zuluaga <[email protected]>
@pritipath
Copy link
Contributor Author

@Willmish @vaughanknight This is ready for GSF review

@Willmish
Copy link
Collaborator

Hi @pritipath and thanks for adding the correct diagram! Regarding the DCO, if you could please fix this before it gets merged in, you have added a remediation for ec4270a but not for d9fdbe3 - please see issue #309 for possible suggestions on how to fix this - for example Fabio's comment explains a nice method with git rebasing: #309 (comment)) OR SEE BELOW for suggested course of action.

Preferably you would also remove the 2 empty commits with incorrect DCO remediation. To do this:

  1. git reset --hard HEAD~2 will permanently REMOVE the last two commits from local repo OR git reset --hard d9fdbe36c2a31c05a917cdc8817bdf5e4fe2474f will do the same but reset exactly to this commit: d9fdbe3 , removing the empty incorrect remediation commit and the commit adding the single space.
  2. NEXT, instead of git commit --amend -s you can add a correct remediation commit FOR BOTH unsigned commits, with :
git commit -m"DCO Remediation Commit for Priti <[email protected]>

I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: ec4270a559d1ac3624d068f8ae48925f68cfe3b2
I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: d9fdbe36c2a31c05a917cdc8817bdf5e4fe2474f

Signed-off-by: Priti <[email protected]>" --allow-empty
  1. Finally, you can git push -f which will rewrite the upstream repo history on this branch.

Hopefully this is will help you out in fixing the issue!

Copy link
Collaborator

@Willmish Willmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diagram looks good, but please see DCO comment.

@Willmish
Copy link
Collaborator

#363 - @pritipath resurfacing

I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: ec4270a
I, Priti <[email protected]>, hereby add my Signed-off-by to this commit: d9fdbe3

Signed-off-by: Priti <[email protected]>
@pritipath pritipath force-pushed the 352-update_arch_diag branch from 975b339 to 8450995 Compare June 13, 2023 16:41
@pritipath
Copy link
Contributor Author

#363 - @pritipath resurfacing

@Willmish Fixed. Sorry for the delay, missed this somehow.

@github-actions
Copy link
Contributor

This a stale pull request. Please review, update or/and close as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation refers to old architecture diagram
4 participants