Add workaround for input event problems in MongoInputStatusService #7993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waab76
requested changes
Apr 28, 2020
Comment on lines
191
to
211
| public void handleDeleteEvent_DoesNothing() throws Exception { | ||
| final String deletedInput = "54e3deadbeefdeadbeef0001"; | ||
| final InputDeleted inputDeletedEvent = new InputDeleted() { | ||
| @Override | ||
| public String id() { | ||
| return "54e3deadbeefdeadbeef0001"; | ||
| return deletedInput; | ||
| } | ||
| }); | ||
| }; | ||
|
|
||
| cut.handleInputDeleted(inputDeletedEvent); | ||
| // The record should not be removed from the DB | ||
| Optional<InputStatusRecord> optDbRecord = cut.get("54e3deadbeefdeadbeef0001"); | ||
| assertThat(cut.get(deletedInput).isPresent(), is(true)); | ||
|
|
||
| assertThat(optDbRecord, notNullValue()); | ||
| assertThat(optDbRecord.isPresent(), is(true)); | ||
| // Simulate that the input has actually been deleted | ||
| // TODO: This will change once we fix https://github.com/Graylog2/graylog2-server/issues/7812 | ||
| when(inputService.find(deletedInput)).thenThrow(new NotFoundException()); | ||
|
|
||
| cut.handleInputDeleted(inputDeletedEvent); | ||
| // The record should be removed from the DB | ||
| assertThat(cut.get(deletedInput).isPresent(), is(false)); | ||
| } |
There was a problem hiding this comment.
This should be split into two separate tests to make it easier to see if a change breaks one but not the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the problem described in #7812.
When we receive an "InputDeleted" event, check if the input still exists
in the database. If so, the input has only been stopped and we don't
want to delete our state.
Refs #7812