Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented code #5756

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Remove commented code #5756

merged 1 commit into from
Mar 14, 2019

Conversation

kyleknighted
Copy link
Contributor

Previous PR #5748 for this issue had commented code.
This PR removes commented code only.

Motivation and Context

Remove commented code

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Previous PR #5748 for this issue had commented code.
This PR removes commented code only.
@dennisoelkers
Copy link
Member

@kyleknighted: Unfortunately I was not able to leave a review before #5478 was merged. I noticed that the placement of the logo is now different.

Before:

Screen Shot 2019-03-11 at 11 54 34

After:

Screen Shot 2019-03-11 at 11 55 45

There is now less padding around it, especially on the left side. Is this on purpose?

@kyleknighted
Copy link
Contributor Author

@dennisoelkers It was intentional. I aligned the left side to the other elements on the site and removed some of the padding off to the right that felt superfluous.

I can gladly make any adjustments if you feel like the logo needs additional "breathing room".

@dennisoelkers
Copy link
Member

Okay, just wanted to make sure it was intentional and not accidental. I also like the more compact version better.

@edmundoa edmundoa merged commit 1aa4033 into master Mar 14, 2019
@edmundoa edmundoa deleted the issue-5747-b branch March 14, 2019 14:27
@lennartkoopmann
Copy link
Contributor

The Chief Margin and Padding Officer (CMPO) approves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants