Fix to load indices status in batches so that the URL used to call OpenSearch does not exceed maximum length #21208
+104
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks for this! Some suggestions for improvement:
- We should try to use an endpoint where we can get results in a single response to avoid multiple round-trips. We could use
/_settings/index.blocks.read,index.blocks.write,index.blocks.metadatafor example. - We could do this, when
indices.stream().collect(joining(",")).length > threshold - Should we also implement this for the ES7 module?
| final GetSettingsResponse settingsResponse = c.indices().getSettings(getSettingsRequest, requestOptions); | ||
| return BlockSettingsParser.parseBlockSettings(settingsResponse); | ||
| }); | ||
| if(String.join(",", indices).length() > MAX_INDICES_URL_LENGTH) { |
There was a problem hiding this comment.
I think we should safe some buffer here, as there will also be the path + additional query parameters (+ potential url encoding overhead?). Let's play it safe and reduce MAX_INDICES_URL_LENGTH to 2500?
| }); | ||
| if(String.join(",", indices).length() > MAX_INDICES_URL_LENGTH) { | ||
| final GetSettingsRequest getSettingsRequest = new GetSettingsRequest() | ||
| .indicesOptions(IndicesOptions.fromOptions(false, true, true, true)) |
There was a problem hiding this comment.
Can we use .names("index.blocks.read", ...) to get only the blocks here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, a call to
getIndicesBlocksStatus()would exceed to URL maximum of 4096 bytes if the number of indices would be large. This PR mitigates the problem by getting the status in batches and merges the result. IMotivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: