Improve performance for working with indices #21195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead use `getForIndex(String)` directly. Also converted some loops to streaming.
|
|
|
Needs a changelog or /nocl directive. |
|
I see, thanks for the pointer! |
patrickmann
requested changes
Dec 16, 2024
graylog2-server/src/main/java/org/graylog2/indexer/MongoIndexSetRegistry.java
Show resolved
Hide resolved
graylog2-server/src/test/java/org/graylog2/indexer/MongoIndexSetRegistryTest.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/test/java/org/graylog2/indexer/MongoIndexSetRegistryTest.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/test/java/org/graylog2/indexer/MongoIndexSetRegistryTest.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog2/indexer/MongoIndexSetRegistry.java
Show resolved
Hide resolved
patrickmann
reviewed
Dec 16, 2024
graylog2-server/src/test/java/org/graylog2/indexer/MongoIndexSetRegistryTest.java
Outdated
Show resolved
Hide resolved
patrickmann
reviewed
Dec 16, 2024
patrickmann
approved these changes
Dec 18, 2024
|
Hi @bernd , can we get a backport of this fix to 6.1? Thanks! |
9 tasks
patrickmann
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Improve performance for working with indices (#21195) * Issue #18563: Don't iterate over all IndexSets for a given indexName, instead use `getForIndex(String)` directly. Also converted some loops to streaming. * Add changelog * Review comments * Review comments part two (cherry picked from commit 7845ab9) * Added PR for backport to 6.1 to the list of PR's --------- Co-authored-by: Florian Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't iterate over all IndexSets for a given indexName, instead use
getForIndex(String)directly to avoid unnecessary calls. Also converted some loops to streaming for further cleanup of the code.Motivation and Context
Fixes issue #18563.
How Has This Been Tested?
There's an new test to simulate having 500 IndexSets and checking if only the one responsible for a given specific index is being called.
Types of changes
Checklist: