Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opensearch code cleanup #21177

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Opensearch code cleanup #21177

merged 3 commits into from
Dec 17, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Dec 12, 2024 •
edited
Loading

  • Simplified heap configuration
  • Removed unused opensearch-observability configuration files

/nocl refactoring

Description

Simplify configuration, use the heap from the config directly.

Motivation and Context

Code cleanup

How Has This Been Tested?

Existing unit and integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld December 12, 2024 12:02
@todvora todvora changed the title Opensearch heap config property code cleanup Opensearch code cleanup Dec 12, 2024
moesterheld
moesterheld approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm. thank you!

@moesterheld moesterheld merged commit f197bbb into master Dec 17, 2024
6 checks passed
@moesterheld moesterheld deleted the refactoring/opensearch-heap-code-cleanup branch December 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@todvora @moesterheld