Trimming down MoreSearch class.
#21078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
refactor/improve-more-search
branch
from
8f6bed5 to
327ffa6
Compare
patrickmann
approved these changes
Dec 2, 2024
...g2-server/src/main/java/org/graylog/events/processor/aggregation/PivotAggregationSearch.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is a refactoring attempting to reduce the
MoreSearchclass, which is a hacky workaround to implement searches in the events/alerting system. It duplicates multiple aspects of other classes and should be removed. This PR is focussing on fetching streams, replacing it withStreamService#loadByIdandPermittedStreams./nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: